From 0bc2923ef75d233ac70c4ee68a7ff8e302faeeb0 Mon Sep 17 00:00:00 2001 From: Kira Bruneau Date: Tue, 20 May 2025 22:53:21 -0400 Subject: [PATCH] Revert "buildNodePackage: enable strictDeps" This reverts commit e0705250d2b9b192aa0ee430d61e4039c91d1f55, which broke patching `#!/usr/bin/env node` shebangs. It also modified a generated file, which would get reverted the next time node-env.nix is regenerated. If we want to enable strictDeps for node packages we should update node2nix instead. --- pkgs/development/node-packages/node-env.nix | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/pkgs/development/node-packages/node-env.nix b/pkgs/development/node-packages/node-env.nix index f5a9db742566..4154ce72634c 100644 --- a/pkgs/development/node-packages/node-env.nix +++ b/pkgs/development/node-packages/node-env.nix @@ -540,17 +540,16 @@ let in stdenv.mkDerivation ( { - name = name + lib.optionalString (version != null) "-${version}"; - strictDeps = true; + name = "${name}${if version == null then "" else "-${version}"}"; buildInputs = - [ tarWrapper ] + [ + tarWrapper + python + nodejs + ] ++ lib.optional (stdenv.hostPlatform.isLinux) pkgs.util-linux ++ lib.optional (stdenv.hostPlatform.isDarwin) libtool ++ buildInputs; - propagatedNativeBuildInputs = [ - nodejs - python - ]; inherit nodejs;