From 5eb75bf013ce37956b6ba501f79d2c2e1d18df10 Mon Sep 17 00:00:00 2001
From: OPNA2608 <opna2608@protonmail.com>
Date: Fri, 6 Dec 2024 00:03:32 +0100
Subject: [PATCH] sidplayfp: Modernise

- nixfmt
- Drop meta-wide "with lib"
- Add meta.changelog
- Use gitUpdater
---
 pkgs/by-name/si/sidplayfp/package.nix | 65 +++++++++++++++------------
 1 file changed, 37 insertions(+), 28 deletions(-)

diff --git a/pkgs/by-name/si/sidplayfp/package.nix b/pkgs/by-name/si/sidplayfp/package.nix
index d48ba980a53f..d396dec60c0e 100644
--- a/pkgs/by-name/si/sidplayfp/package.nix
+++ b/pkgs/by-name/si/sidplayfp/package.nix
@@ -1,17 +1,18 @@
-{ stdenv
-, lib
-, fetchFromGitHub
-, nix-update-script
-, alsaSupport ? stdenv.hostPlatform.isLinux
-, alsa-lib
-, autoreconfHook
-, pulseSupport ? stdenv.hostPlatform.isLinux
-, libpulseaudio
-, libsidplayfp
-, out123Support ? stdenv.hostPlatform.isDarwin
-, mpg123
-, perl
-, pkg-config
+{
+  stdenv,
+  lib,
+  fetchFromGitHub,
+  gitUpdater,
+  alsaSupport ? stdenv.hostPlatform.isLinux,
+  alsa-lib,
+  autoreconfHook,
+  pulseSupport ? stdenv.hostPlatform.isLinux,
+  libpulseaudio,
+  libsidplayfp,
+  out123Support ? stdenv.hostPlatform.isDarwin,
+  mpg123,
+  perl,
+  pkg-config,
 }:
 
 stdenv.mkDerivation (finalAttrs: {
@@ -33,15 +34,19 @@ stdenv.mkDerivation (finalAttrs: {
     pkg-config
   ];
 
-  buildInputs = [
-    libsidplayfp
-  ] ++ lib.optionals alsaSupport [
-    alsa-lib
-  ] ++ lib.optionals pulseSupport [
-    libpulseaudio
-  ] ++ lib.optionals out123Support [
-    mpg123
-  ];
+  buildInputs =
+    [
+      libsidplayfp
+    ]
+    ++ lib.optionals alsaSupport [
+      alsa-lib
+    ]
+    ++ lib.optionals pulseSupport [
+      libpulseaudio
+    ]
+    ++ lib.optionals out123Support [
+      mpg123
+    ];
 
   configureFlags = [
     (lib.strings.withFeature out123Support "out123")
@@ -50,15 +55,19 @@ stdenv.mkDerivation (finalAttrs: {
   enableParallelBuilding = true;
 
   passthru = {
-    updateScript = nix-update-script { };
+    updateScript = gitUpdater { rev-prefix = "v"; };
   };
 
-  meta = with lib; {
+  meta = {
     description = "SID player using libsidplayfp";
     homepage = "https://github.com/libsidplayfp/sidplayfp";
-    license = with licenses; [ gpl2Plus ];
+    changelog = "https://github.com/libsidplayfp/sidplayfp/releases/tag/v${finalAttrs.version}";
+    license = with lib.licenses; [ gpl2Plus ];
     mainProgram = "sidplayfp";
-    maintainers = with maintainers; [ dezgeg OPNA2608 ];
-    platforms = platforms.all;
+    maintainers = with lib.maintainers; [
+      dezgeg
+      OPNA2608
+    ];
+    platforms = lib.platforms.all;
   };
 })