From f24ba4158853e56ccbe843616b8a54e888600903 Mon Sep 17 00:00:00 2001 From: Sarah Clark Date: Mon, 1 Dec 2025 11:58:34 -0800 Subject: [PATCH] python3Packages.gst-python: fix installCheckPhase Tests weren't calling `preCheck` as expected which is probably why the tests failed in Darwin on Hydra. --- pkgs/development/python-modules/gst-python/default.nix | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/pkgs/development/python-modules/gst-python/default.nix b/pkgs/development/python-modules/gst-python/default.nix index 1ac7962800a6..52c3119e435f 100644 --- a/pkgs/development/python-modules/gst-python/default.nix +++ b/pkgs/development/python-modules/gst-python/default.nix @@ -89,14 +89,14 @@ buildPythonPackage rec { (lib.mesonEnable "tests" gst-python.doInstallCheck) ]; - # Tests are very flaky on Darwin. - # See: https://github.com/NixOS/nixpkgs/issues/454955 - doCheck = !stdenv.hostPlatform.isDarwin; - # `buildPythonPackage` uses `installCheckPhase` and leaves `checkPhase` # empty. It renames `doCheck` from its arguments, but not `checkPhase`. # See: https://github.com/NixOS/nixpkgs/issues/47390 - installCheckPhase = "mesonCheckPhase"; + installCheckPhase = '' + runHook preCheck + mesonCheckPhase + runHook postCheck + ''; preCheck = lib.optionalString stdenv.hostPlatform.isDarwin '' export DYLD_LIBRARY_PATH="${gst_all_1.gst-plugins-base}/lib"