From 5d09f1a60c3ea2f0e99b76eed8774313ef5be3c6 Mon Sep 17 00:00:00 2001 From: Randy Eckenrode Date: Mon, 14 Apr 2025 20:13:04 -0400 Subject: [PATCH] bazel_{5,6,7}: get libc++ headers on Darwin from stdenv.cc.libcxx --- .../tools/build-managers/bazel/bazel_5/default.nix | 4 +--- .../tools/build-managers/bazel/bazel_6/default.nix | 4 +--- .../tools/build-managers/bazel/bazel_7/default.nix | 4 +--- 3 files changed, 3 insertions(+), 9 deletions(-) diff --git a/pkgs/development/tools/build-managers/bazel/bazel_5/default.nix b/pkgs/development/tools/build-managers/bazel/bazel_5/default.nix index 882d7891a4f0..e63331148b6e 100644 --- a/pkgs/development/tools/build-managers/bazel/bazel_5/default.nix +++ b/pkgs/development/tools/build-managers/bazel/bazel_5/default.nix @@ -28,7 +28,6 @@ writeScript, # Apple dependencies cctools, - libcxx, sigtool, # Allow to independently override the jdks used to build and run respectively buildJdk, @@ -451,7 +450,7 @@ stdenv.mkDerivation rec { # libcxx includes aren't added by libcxx hook # https://github.com/NixOS/nixpkgs/pull/41589 - export NIX_CFLAGS_COMPILE="$NIX_CFLAGS_COMPILE -isystem ${lib.getDev libcxx}/include/c++/v1" + export NIX_CFLAGS_COMPILE="$NIX_CFLAGS_COMPILE -isystem ${lib.getInclude stdenv.cc.libcxx}/include/c++/v1" # for CLang 16 compatibility in external/{absl,upb} dependencies and in execlog export NIX_CFLAGS_COMPILE+=" -Wno-deprecated-builtins -Wno-gnu-offsetof-extensions -Wno-implicit-function-declaration" @@ -622,7 +621,6 @@ stdenv.mkDerivation rec { ] ++ lib.optionals (stdenv.hostPlatform.isDarwin) [ cctools - libcxx ]; # Bazel makes extensive use of symlinks in the WORKSPACE. diff --git a/pkgs/development/tools/build-managers/bazel/bazel_6/default.nix b/pkgs/development/tools/build-managers/bazel/bazel_6/default.nix index d1d1ca10abae..81bdd88b2e03 100644 --- a/pkgs/development/tools/build-managers/bazel/bazel_6/default.nix +++ b/pkgs/development/tools/build-managers/bazel/bazel_6/default.nix @@ -31,7 +31,6 @@ writeScript, # Apple dependencies cctools, - libcxx, sigtool, # Allow to independently override the jdks used to build and run respectively buildJdk, @@ -521,7 +520,7 @@ stdenv.mkDerivation rec { # libcxx includes aren't added by libcxx hook # https://github.com/NixOS/nixpkgs/pull/41589 - export NIX_CFLAGS_COMPILE="$NIX_CFLAGS_COMPILE -isystem ${lib.getDev libcxx}/include/c++/v1" + export NIX_CFLAGS_COMPILE="$NIX_CFLAGS_COMPILE -isystem ${lib.getInclude stdenv.cc.libcxx}/include/c++/v1" # for CLang 16 compatibility in external/{absl,upb} dependencies export NIX_CFLAGS_COMPILE+=" -Wno-deprecated-builtins -Wno-gnu-offsetof-extensions" @@ -690,7 +689,6 @@ stdenv.mkDerivation rec { ] ++ lib.optionals (stdenv.hostPlatform.isDarwin) [ cctools - libcxx sigtool ]; diff --git a/pkgs/development/tools/build-managers/bazel/bazel_7/default.nix b/pkgs/development/tools/build-managers/bazel/bazel_7/default.nix index 613f04f84c91..6c4820d9894e 100644 --- a/pkgs/development/tools/build-managers/bazel/bazel_7/default.nix +++ b/pkgs/development/tools/build-managers/bazel/bazel_7/default.nix @@ -34,7 +34,6 @@ python3, # Apple dependencies cctools, - libcxx, libtool, sigtool, # Allow to independently override the jdks used to build and run respectively @@ -406,7 +405,7 @@ stdenv.mkDerivation rec { # libcxx includes aren't added by libcxx hook # https://github.com/NixOS/nixpkgs/pull/41589 - export NIX_CFLAGS_COMPILE="$NIX_CFLAGS_COMPILE -isystem ${lib.getDev libcxx}/include/c++/v1" + export NIX_CFLAGS_COMPILE="$NIX_CFLAGS_COMPILE -isystem ${lib.getInclude stdenv.cc.libcxx}/include/c++/v1" # for CLang 16 compatibility in external/upb dependency export NIX_CFLAGS_COMPILE+=" -Wno-gnu-offsetof-extensions" @@ -554,7 +553,6 @@ stdenv.mkDerivation rec { ] ++ lib.optionals (stdenv.hostPlatform.isDarwin) [ cctools - libcxx ]; # Bazel makes extensive use of symlinks in the WORKSPACE.