From 693393d3aae314433b24f4a610f8d4c8a397b27c Mon Sep 17 00:00:00 2001 From: Adam Stephens Date: Sun, 5 May 2024 18:39:40 -0400 Subject: [PATCH 1/2] s0ix-selftest-tool: unstable-2022-11-04 -> 0-unstable-2024-02-07 switched from resholve to a wrapper. the tool has had many improvements since last updated, so can be handled with wrapProgram now. resholve is also apparently incompatible with unstableGitUpdater. --- .../system/s0ix-selftest-tool/default.nix | 63 +++++++++---------- 1 file changed, 28 insertions(+), 35 deletions(-) diff --git a/pkgs/tools/system/s0ix-selftest-tool/default.nix b/pkgs/tools/system/s0ix-selftest-tool/default.nix index 535a68f6ff75..89b5c104aa98 100644 --- a/pkgs/tools/system/s0ix-selftest-tool/default.nix +++ b/pkgs/tools/system/s0ix-selftest-tool/default.nix @@ -1,6 +1,5 @@ { acpica-tools, - bash, bc, coreutils, fetchFromGitHub, @@ -11,71 +10,65 @@ lib, pciutils, powertop, - resholve, + makeWrapper, + stdenv, + unstableGitUpdater, util-linux, xorg, xxd, }: -resholve.mkDerivation { + +let + deps = [ + acpica-tools + bc + coreutils + gawk + gnugrep + gnused + linuxPackages.turbostat + pciutils + powertop + util-linux + xorg.xset + xxd + ]; +in +stdenv.mkDerivation { pname = "s0ix-selftest-tool"; - version = "unstable-2022-11-04"; + version = "0-unstable-2024-02-07"; src = fetchFromGitHub { owner = "intel"; repo = "S0ixSelftestTool"; - rev = "1b6db3c3470a3a74b052cb728a544199661d18ec"; - hash = "sha256-w97jfdppW8kC8K8XvBntmkfntIctXDQCWmvug+H1hKA="; + rev = "c12ae3ea611812547e09bb755dd015dd969b664c"; + hash = "sha256-9O72TxlLrkQbt80izWdbLQt9OW/4Aq1p4RuQoD2yQ5E="; }; # don't use the bundled turbostat binary postPatch = '' substituteInPlace s0ix-selftest-tool.sh --replace '"$DIR"/turbostat' 'turbostat' - substituteInPlace s0ix-selftest-tool.sh --replace 'sudo ' "" - ''; + nativeBuildInputs = [ makeWrapper ]; dontConfigure = true; dontBuild = true; installPhase = '' runHook preInstall install -Dm555 s0ix-selftest-tool.sh "$out/bin/s0ix-selftest-tool" + wrapProgram "$out/bin/s0ix-selftest-tool" --prefix PATH : ${lib.escapeShellArg deps} runHook postInstall ''; - solutions = { - default = { - scripts = ["bin/s0ix-selftest-tool"]; - interpreter = lib.getExe bash; - inputs = [ - acpica-tools - bc - coreutils - gawk - gnugrep - gnused - linuxPackages.turbostat - pciutils - powertop - util-linux - xorg.xset - xxd - ]; - execer = [ - "cannot:${util-linux}/bin/dmesg" - "cannot:${powertop}/bin/powertop" - "cannot:${util-linux}/bin/rtcwake" - "cannot:${linuxPackages.turbostat}/bin/turbostat" - ]; - }; - }; + passthru.updateScript = unstableGitUpdater { }; meta = with lib; { homepage = "https://github.com/intel/S0ixSelftestTool"; description = "A tool for testing the S2idle path CPU Package C-state and S0ix failures"; license = licenses.gpl2Only; platforms = platforms.linux; - maintainers = with maintainers; [adamcstephens]; + maintainers = with maintainers; [ adamcstephens ]; mainProgram = "s0ix-selftest-tool"; }; } From 0dc23f226c2557dd1444c1d082d2f93a728316ff Mon Sep 17 00:00:00 2001 From: Adam Stephens Date: Sun, 5 May 2024 18:45:51 -0400 Subject: [PATCH 2/2] s0ix-selftest-tool: move to by-name --- .../default.nix => by-name/s0/s0ix-selftest-tool/package.nix} | 0 pkgs/top-level/all-packages.nix | 2 -- 2 files changed, 2 deletions(-) rename pkgs/{tools/system/s0ix-selftest-tool/default.nix => by-name/s0/s0ix-selftest-tool/package.nix} (100%) diff --git a/pkgs/tools/system/s0ix-selftest-tool/default.nix b/pkgs/by-name/s0/s0ix-selftest-tool/package.nix similarity index 100% rename from pkgs/tools/system/s0ix-selftest-tool/default.nix rename to pkgs/by-name/s0/s0ix-selftest-tool/package.nix diff --git a/pkgs/top-level/all-packages.nix b/pkgs/top-level/all-packages.nix index 1e09e4f57092..944d26a2ef9e 100644 --- a/pkgs/top-level/all-packages.nix +++ b/pkgs/top-level/all-packages.nix @@ -2025,8 +2025,6 @@ with pkgs; ronin = callPackage ../tools/security/ronin { }; - s0ix-selftest-tool = callPackage ../tools/system/s0ix-selftest-tool { }; - scarab = callPackage ../tools/games/scarab { }; sdbus-cpp = callPackage ../development/libraries/sdbus-cpp { };