From 5a8d0803baa6bee0a8778b3af41676674575baf4 Mon Sep 17 00:00:00 2001
From: Pavol Rusnak <pavol@rusnak.io>
Date: Sun, 16 Feb 2025 23:47:43 +0100
Subject: [PATCH] magma: build latest with rocmPackages_6

---
 .../libraries/science/math/magma/generic.nix  | 46 +++++++++++++------
 1 file changed, 33 insertions(+), 13 deletions(-)

diff --git a/pkgs/development/libraries/science/math/magma/generic.nix b/pkgs/development/libraries/science/math/magma/generic.nix
index 6f0cdf91c52a..39062859f2bc 100644
--- a/pkgs/development/libraries/science/math/magma/generic.nix
+++ b/pkgs/development/libraries/science/math/magma/generic.nix
@@ -13,9 +13,11 @@
   cudaPackages,
   cudaSupport ? config.cudaSupport,
   fetchurl,
+  fetchpatch,
   gfortran,
   gpuTargets ? [ ], # Non-CUDA targets, that is HIP
-  rocmPackages_5,
+  rocmPackages_5 ? null,
+  rocmPackages,
   lapack,
   lib,
   libpthreadstubs,
@@ -46,8 +48,8 @@ let
 
   inherit (effectiveCudaPackages) cudaAtLeast flags cudaOlder;
 
-  # move to newer ROCm version once supported
-  rocmPackages = rocmPackages_5;
+  effectiveRocmPackages =
+    if strings.versionOlder version "2.8.0" then rocmPackages_5 else rocmPackages;
 
   # NOTE: The lists.subtractLists function is perhaps a bit unintuitive. It subtracts the elements
   #   of the first list *from* the second list. That means:
@@ -57,7 +59,7 @@ let
   # NOTE: The hip.gpuTargets are prefixed with "gfx" instead of "sm" like flags.realArches.
   #   For some reason, Magma's CMakeLists.txt file does not handle the "gfx" prefix, so we must
   #   remove it.
-  rocmArches = lists.map (x: strings.removePrefix "gfx" x) rocmPackages.clr.gpuTargets;
+  rocmArches = lists.map (x: strings.removePrefix "gfx" x) effectiveRocmPackages.clr.gpuTargets;
   supportedRocmArches = lists.intersectLists rocmArches supportedGpuTargets;
   unsupportedRocmArches = lists.subtractLists supportedRocmArches rocmArches;
 
@@ -115,6 +117,15 @@ stdenv.mkDerivation {
     "test"
   ];
 
+  patches = lib.optionals (version == "2.9.0") [
+    # get ROCm version directly
+    # https://github.com/icl-utk-edu/magma/pull/27
+    (fetchpatch {
+      url = "https://github.com/icl-utk-edu/magma/commit/10fe816b763c41099fa1c978a79d6869246671cf.patch";
+      hash = "sha256-qSY5ACMHyHofJdQKyPqx8sI8GbPD6IZezmCd8qOS5OM=";
+    })
+  ];
+
   # Fixup for the python test runners
   postPatch =
     ''
@@ -163,12 +174,15 @@ stdenv.mkDerivation {
         cuda_cccl # <nv/target>
       ]
     )
-    ++ lists.optionals rocmSupport [
-      rocmPackages.clr
-      rocmPackages.hipblas
-      rocmPackages.hipsparse
-      rocmPackages.llvm.openmp
-    ];
+    ++ lists.optionals rocmSupport (
+      with effectiveRocmPackages;
+      [
+        clr
+        hipblas
+        hipsparse
+        llvm.openmp
+      ]
+    );
 
   cmakeFlags =
     [
@@ -189,8 +203,8 @@ stdenv.mkDerivation {
       (strings.cmakeFeature "MIN_ARCH" minArch) # Disarms magma's asserts
     ]
     ++ lists.optionals rocmSupport [
-      (strings.cmakeFeature "CMAKE_C_COMPILER" "${rocmPackages.clr}/bin/hipcc")
-      (strings.cmakeFeature "CMAKE_CXX_COMPILER" "${rocmPackages.clr}/bin/hipcc")
+      (strings.cmakeFeature "CMAKE_C_COMPILER" "${effectiveRocmPackages.clr}/bin/hipcc")
+      (strings.cmakeFeature "CMAKE_CXX_COMPILER" "${effectiveRocmPackages.clr}/bin/hipcc")
     ];
 
   # Magma doesn't have a test suite we can easily run, just loose executables, all of which require a GPU.
@@ -244,6 +258,12 @@ stdenv.mkDerivation {
       (cudaSupport && !static)
       || !(cudaSupport || rocmSupport) # At least one back-end enabled
       || (cudaSupport && rocmSupport) # Mutually exclusive
-      || (cudaSupport && strings.versionOlder version "2.7.1" && cudaPackages_11 == null);
+      || (cudaSupport && strings.versionOlder version "2.7.1" && cudaPackages_11 == null)
+      || (rocmSupport && strings.versionOlder version "2.8.0" && rocmPackages_5 == null)
+      || (
+        rocmSupport
+        && strings.versionAtLeast version "2.8.0"
+        && strings.versionOlder rocmPackages.clr.version "6.3"
+      );
   };
 }