From 595e2e9581b660f9dd37f7e7983e9298b0986fb4 Mon Sep 17 00:00:00 2001 From: Pol Dellaiera Date: Sat, 19 Jul 2025 10:07:56 +0200 Subject: [PATCH] glab: enable `versionCheckHook` --- pkgs/by-name/gl/glab/package.nix | 20 +++++++++++++++----- 1 file changed, 15 insertions(+), 5 deletions(-) diff --git a/pkgs/by-name/gl/glab/package.nix b/pkgs/by-name/gl/glab/package.nix index b0430bff803d..960ca9c5b5fd 100644 --- a/pkgs/by-name/gl/glab/package.nix +++ b/pkgs/by-name/gl/glab/package.nix @@ -7,6 +7,7 @@ stdenv, nix-update-script, writableTmpDirAsHomeHook, + versionCheckHook, gitMinimal, }: @@ -39,7 +40,10 @@ buildGoModule (finalAttrs: { ldflags+=" -X main.commit=$(cat COMMIT)" ''; - nativeBuildInputs = [ installShellFiles makeBinaryWrapper ]; + nativeBuildInputs = [ + installShellFiles + makeBinaryWrapper + ]; subPackages = [ "cmd/glab" ]; @@ -56,15 +60,21 @@ buildGoModule (finalAttrs: { --set-default GLAB_SEND_TELEMETRY 0 ''; - nativeCheckInputs = [ - gitMinimal - writableTmpDirAsHomeHook - ]; + nativeCheckInputs = [ writableTmpDirAsHomeHook ]; preCheck = '' git init ''; + doInstallCheck = true; + nativeInstallCheckInputs = [ + gitMinimal + versionCheckHook + writableTmpDirAsHomeHook + ]; + versionCheckProgramArg = "version"; + versionCheckKeepEnvironment = [ "HOME" ]; + passthru.updateScript = nix-update-script { }; meta = {