From 4f67d0e4f84264df6afe634503373b8562d2a48a Mon Sep 17 00:00:00 2001
From: n <54501296+2hexed@users.noreply.github.com>
Date: Fri, 3 Oct 2025 21:17:58 +0530
Subject: [PATCH] nixos/serviio: add option to open firewall ports

I think we should have open firewall ports and let the user choose if they want to have these ports open or not. :D
---
 nixos/modules/services/misc/serviio.nix | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/nixos/modules/services/misc/serviio.nix b/nixos/modules/services/misc/serviio.nix
index 4553a125418e..dac00fe5d481 100644
--- a/nixos/modules/services/misc/serviio.nix
+++ b/nixos/modules/services/misc/serviio.nix
@@ -39,6 +39,14 @@ in
         '';
       };
 
+      openFirewall = lib.mkOption {
+        type = lib.types.bool;
+        default = false;
+        description = ''
+          Open ports in the firewall for the Serviio Media Server.
+        '';
+      };
+
       dataDir = lib.mkOption {
         type = lib.types.path;
         default = "/var/lib/serviio";
@@ -76,7 +84,7 @@ in
 
     users.groups.serviio = { };
 
-    networking.firewall = {
+    networking.firewall = lib.mkIf cfg.openFirewall {
       allowedTCPPorts = [
         8895 # serve UPnP responses
         23423 # console