From 6572a49f3c8ba5e1e3aba47c3e86a9c313fa8171 Mon Sep 17 00:00:00 2001 From: Cody P Schafer Date: Wed, 2 Oct 2024 16:24:17 -0400 Subject: [PATCH] natscli: set `main.version=${version}` Otherwise, `natscli --version` reports its version as "development" instead of the version number. Adds versionCheckHook to verify. --- pkgs/tools/system/natscli/default.nix | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/pkgs/tools/system/natscli/default.nix b/pkgs/tools/system/natscli/default.nix index 613976bcbd9e..68787caff7b2 100644 --- a/pkgs/tools/system/natscli/default.nix +++ b/pkgs/tools/system/natscli/default.nix @@ -1,6 +1,7 @@ { lib , buildGoModule , fetchFromGitHub +, versionCheckHook }: buildGoModule rec { @@ -16,6 +17,14 @@ buildGoModule rec { vendorHash = "sha256-T6VcyklwfRS012ZRzqxkahn9YYrQGky/znTqLIkAoK0="; + ldflags = [ + "-X main.version=${version}" + ]; + + nativeInstallCheckInputs = [ versionCheckHook ]; + doInstallCheck = true; + versionCheckProgram = "${placeholder "out"}/bin/nats"; + meta = with lib; { description = "NATS Command Line Interface"; homepage = "https://github.com/nats-io/natscli";