From 58c665d96c7f3effd6869c2ceca6f00a422d2c2f Mon Sep 17 00:00:00 2001 From: zowoq <59103226+zowoq@users.noreply.github.com> Date: Fri, 20 Aug 2021 17:12:13 +1000 Subject: [PATCH 1/5] docker-machine-xhyve: buildFlags -> tags --- pkgs/applications/networking/cluster/docker-machine/xhyve.nix | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkgs/applications/networking/cluster/docker-machine/xhyve.nix b/pkgs/applications/networking/cluster/docker-machine/xhyve.nix index 8c3534006bf7..86a7d87a0e13 100644 --- a/pkgs/applications/networking/cluster/docker-machine/xhyve.nix +++ b/pkgs/applications/networking/cluster/docker-machine/xhyve.nix @@ -17,7 +17,7 @@ buildGoPackage rec { export CGO_CFLAGS=-I$(pwd)/go/src/${goPackagePath}/vendor/github.com/jceel/lib9p export CGO_LDFLAGS=$(pwd)/go/src/${goPackagePath}/vendor/build/lib9p/lib9p.a ''; - buildFlags = "--tags lib9p"; + tags = [ "lib9p" ]; src = fetchFromGitHub { rev = "v${version}"; From dd07491333d7fdd7f8733a351ec16316ae7a8ef9 Mon Sep 17 00:00:00 2001 From: zowoq <59103226+zowoq@users.noreply.github.com> Date: Fri, 20 Aug 2021 17:12:13 +1000 Subject: [PATCH 2/5] kubebuilder: buildFlagsArray -> ldflags --- .../networking/cluster/kubebuilder/default.nix | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/pkgs/applications/networking/cluster/kubebuilder/default.nix b/pkgs/applications/networking/cluster/kubebuilder/default.nix index 5784c2a472ef..eb29cba7de88 100644 --- a/pkgs/applications/networking/cluster/kubebuilder/default.nix +++ b/pkgs/applications/networking/cluster/kubebuilder/default.nix @@ -20,13 +20,13 @@ buildGoModule rec { subPackages = ["cmd"]; - preBuild = '' - export buildFlagsArray+=("-ldflags=-X main.kubeBuilderVersion=v${version} \ - -X main.goos=$GOOS \ - -X main.goarch=$GOARCH \ - -X main.gitCommit=v${version} \ - -X main.buildDate=v${version}") - ''; + ldflags = [ + "-X main.kubeBuilderVersion=v${version}" + "-X main.goos=${go.GOOS}" + "-X main.goarch=${go.GOARCH}" + "-X main.gitCommit=v${version}" + "-X main.buildDate=v${version}" + ]; doCheck = true; From 10b6e4811af86978b553b8c8d97f2e73d63d897e Mon Sep 17 00:00:00 2001 From: zowoq <59103226+zowoq@users.noreply.github.com> Date: Fri, 20 Aug 2021 17:12:13 +1000 Subject: [PATCH 3/5] aminal: buildFlagsArray -> ldflags --- pkgs/applications/terminal-emulators/aminal/default.nix | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pkgs/applications/terminal-emulators/aminal/default.nix b/pkgs/applications/terminal-emulators/aminal/default.nix index 7f04a93d6a32..70d0d083dcf3 100644 --- a/pkgs/applications/terminal-emulators/aminal/default.nix +++ b/pkgs/applications/terminal-emulators/aminal/default.nix @@ -33,9 +33,9 @@ buildGoPackage rec { sha256 = "0syv9md7blnl6i19zf8s1xjx5vfz6s755fxyg2ply0qc1pwhsj8n"; }; - preBuild = '' - buildFlagsArray=("-ldflags=-X ${goPackagePath}/version.Version=${version}") - ''; + ldflags = [ + "-X ${goPackagePath}/version.Version=${version}" + ]; meta = with lib; { description = "Golang terminal emulator from scratch"; From addcba2e251e7dac40e7491bef123a8435cbc4e5 Mon Sep 17 00:00:00 2001 From: zowoq <59103226+zowoq@users.noreply.github.com> Date: Fri, 20 Aug 2021 17:12:14 +1000 Subject: [PATCH 4/5] kubeprompt: buildFlagsArray -> ldflags --- pkgs/development/tools/kubeprompt/default.nix | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/pkgs/development/tools/kubeprompt/default.nix b/pkgs/development/tools/kubeprompt/default.nix index 39cd59cbec6c..7b60e870958e 100644 --- a/pkgs/development/tools/kubeprompt/default.nix +++ b/pkgs/development/tools/kubeprompt/default.nix @@ -11,12 +11,10 @@ buildGoModule rec { sha256 = "1a0xi31bd7n2zrx2z4srhvixlbj028h63dlrjzqxgmgn2w6akbz2"; }; - preBuild = '' - export buildFlagsArray+=( - "-ldflags= - -w -s - -X github.com/jlesquembre/kubeprompt/pkg/version.Version=${version}") - ''; + ldflags = [ + "-w" "-s" + "-X github.com/jlesquembre/kubeprompt/pkg/version.Version=${version}" + ]; vendorSha256 = "089lfkvyf00f05kkmr935jbrddf2c0v7m2356whqnz7ad6a2whsi"; From f058b02a1731c23d4eedc2cab3440f1bb2e95fb7 Mon Sep 17 00:00:00 2001 From: zowoq <59103226+zowoq@users.noreply.github.com> Date: Fri, 20 Aug 2021 17:12:14 +1000 Subject: [PATCH 5/5] alertmanager-bot: buildFlagsArray -> ldflags --- pkgs/servers/monitoring/alertmanager-bot/default.nix | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/pkgs/servers/monitoring/alertmanager-bot/default.nix b/pkgs/servers/monitoring/alertmanager-bot/default.nix index 9fb364de1915..2d36dcb8e1d5 100644 --- a/pkgs/servers/monitoring/alertmanager-bot/default.nix +++ b/pkgs/servers/monitoring/alertmanager-bot/default.nix @@ -17,11 +17,9 @@ buildGoModule rec { sed "s;/templates/default.tmpl;$out/share&;" -i cmd/alertmanager-bot/main.go ''; - preBuild = '' - export buildFlagsArray=( - "-ldflags=-s -w -X main.Version=v${version} -X main.Revision=${src.rev}" - ) - ''; + ldflags = [ + "-s" "-w" "-X main.Version=v${version}" "-X main.Revision=${src.rev}" + ]; postInstall = '' install -Dm644 -t $out/share/templates $src/default.tmpl