treewide: clean up 'meta = with' pattern

This commit was created by a combination of scripts and tools:
- an ast-grep script to prefix things in meta with `lib.`,
- a modified nixf-diagnose / nixf combination to remove unused `with
lib;`, and
- regular nixfmt.

Co-authored-by: Wolfgang Walther <walther@technowledgy.de>

pkgs/shells/fish/babelfish.nix

@@ -16,12 +16,12 @@ buildGoModule rec {
 
   vendorHash = "sha256-HY9ejLfT6gj3vUMSzbNZ4QlpB+liigTtNDBNWCy8X38=";
 
-  meta = with lib; {
+  meta = {
     description = "Translate bash scripts to fish";
     mainProgram = "babelfish";
     homepage = "https://github.com/bouk/babelfish";
-    license = licenses.mit;
-    maintainers = with maintainers; [
+    license = lib.licenses.mit;
+    maintainers = with lib.maintainers; [
       bouk
       kevingriffin
     ];

pkgs/shells/fish/plugins/async-prompt.nix

@@ -15,10 +15,10 @@ buildFishPlugin rec {
     hash = "sha256-B7Ze0a5Zp+5JVsQUOv97mKHh5wiv3ejsDhJMrK7YOx4=";
   };
 
-  meta = with lib; {
+  meta = {
     description = "Make your prompt asynchronous to improve the reactivity";
     homepage = "https://github.com/acomagu/fish-async-prompt";
-    license = licenses.mit;
+    license = lib.licenses.mit;
     maintainers = [ ];
   };
 }

pkgs/shells/fish/plugins/autopair.nix

@@ -15,11 +15,11 @@ buildFishPlugin rec {
     sha256 = "sha256-s1o188TlwpUQEN3X5MxUlD/2CFCpEkWu83U9O+wg3VU=";
   };
 
-  meta = with lib; {
+  meta = {
     description = "Auto-complete matching pairs in the Fish command line";
     homepage = "https://github.com/jorgebucaran/autopair.fish";
-    license = licenses.mit;
-    maintainers = with maintainers; [
+    license = lib.licenses.mit;
+    maintainers = with lib.maintainers; [
       kidonng
     ];
   };

pkgs/shells/fish/plugins/bass.nix

@@ -26,9 +26,9 @@ buildFishPlugin rec {
     make test
   '';
 
-  meta = with lib; {
+  meta = {
     description = "Fish function making it easy to use utilities written for Bash in Fish shell";
     homepage = "https://github.com/edc/bass";
-    license = licenses.mit;
+    license = lib.licenses.mit;
   };
 }

pkgs/shells/fish/plugins/bobthefish.nix

@@ -14,10 +14,10 @@ buildFishPlugin {
     sha256 = "sha256-cXOYvdn74H4rkMWSC7G6bT4wa9d3/3vRnKed2ixRnuA=";
   };
 
-  meta = with lib; {
+  meta = {
     description = "Powerline-style, Git-aware fish theme optimized for awesome";
     homepage = "https://github.com/oh-my-fish/theme-bobthefish";
-    license = licenses.mit;
-    maintainers = with maintainers; [ Scrumplex ];
+    license = lib.licenses.mit;
+    maintainers = with lib.maintainers; [ Scrumplex ];
   };
 }

pkgs/shells/fish/plugins/bobthefisher.nix

@@ -14,10 +14,10 @@ buildFishPlugin {
     sha256 = "sha256-l1DHSZa40BX2/4GCjm5E53UOeFEnMioWbZtCW14WX6k=";
   };
 
-  meta = with lib; {
+  meta = {
     description = "Powerline-style, Git-aware fish theme optimized for awesome (fork of bobthefish)";
     homepage = "https://github.com/Scrumplex/bobthefisher";
-    license = licenses.mit;
-    maintainers = with maintainers; [ Scrumplex ];
+    license = lib.licenses.mit;
+    maintainers = with lib.maintainers; [ Scrumplex ];
   };
 }

pkgs/shells/fish/plugins/clownfish.nix

@@ -15,10 +15,10 @@ buildFishPlugin {
     sha256 = "04xvikyrdm6yxh588vbpwvm04fas76pa7sigsaqrip7yh021xxab";
   };
 
-  meta = with lib; {
+  meta = {
     description = "Fish function to mock the behaviour of commands";
     homepage = "https://github.com/IlanCosman/clownfish";
-    license = licenses.mit;
-    maintainers = with maintainers; [ euxane ];
+    license = lib.licenses.mit;
+    maintainers = with lib.maintainers; [ euxane ];
   };
 }

pkgs/shells/fish/plugins/colored-man-pages.nix

@@ -15,10 +15,10 @@ buildFishPlugin {
     sha256 = "0ifqdbaw09hd1ai0ykhxl8735fcsm0x2fwfzsk7my2z52ds60bwa";
   };
 
-  meta = with lib; {
+  meta = {
     description = "Fish shell plugin to colorize man pages";
     homepage = "https://github.com/PatrickF1/colored_man_pages.fish";
-    license = licenses.mit;
-    maintainers = [ maintainers.jocelynthode ];
+    license = lib.licenses.mit;
+    maintainers = [ lib.maintainers.jocelynthode ];
   };
 }

pkgs/shells/fish/plugins/done.nix

@@ -21,10 +21,10 @@ buildFishPlugin rec {
     fishtape test/done.fish
   '';
 
-  meta = with lib; {
+  meta = {
     description = "Automatically receive notifications when long processes finish";
     homepage = "https://github.com/franciscolourenco/done";
-    license = licenses.mit;
-    maintainers = [ maintainers.malo ];
+    license = lib.licenses.mit;
+    maintainers = [ lib.maintainers.malo ];
   };
 }

pkgs/shells/fish/plugins/fifc.nix

@@ -14,10 +14,10 @@ buildFishPlugin rec {
     hash = "sha256-p5E4Mx6j8hcM1bDbeftikyhfHxQ+qPDanuM1wNqGm6E=";
   };
 
-  meta = with lib; {
+  meta = {
     description = "Fzf powers on top of fish completion engine and allows customizable completion rules";
     homepage = "https://github.com/gazorby/fifc";
-    license = licenses.mit;
-    maintainers = with maintainers; [ hmajid2301 ];
+    license = lib.licenses.mit;
+    maintainers = with lib.maintainers; [ hmajid2301 ];
   };
 }

pkgs/shells/fish/plugins/fishtape_3.nix

@@ -20,10 +20,10 @@ buildFishPlugin rec {
     fishtape tests/*.fish
   '';
 
-  meta = with lib; {
+  meta = {
     description = "100% pure-Fish test runner";
     homepage = "https://github.com/jorgebucaran/fishtape";
-    license = licenses.mit;
-    maintainers = with maintainers; [ euxane ];
+    license = lib.licenses.mit;
+    maintainers = with lib.maintainers; [ euxane ];
   };
 }

pkgs/shells/fish/plugins/foreign-env/default.nix

@@ -27,10 +27,10 @@ buildFishPlugin {
         -i functions/*
   '';
 
-  meta = with lib; {
+  meta = {
     description = "Foreign environment interface for Fish shell";
-    license = licenses.mit;
-    maintainers = with maintainers; [ jgillich ];
-    platforms = with platforms; unix;
+    license = lib.licenses.mit;
+    maintainers = with lib.maintainers; [ jgillich ];
+    platforms = with lib.platforms; unix;
   };
 }

pkgs/shells/fish/plugins/forgit.nix

@@ -19,10 +19,10 @@ buildFishPlugin rec {
     cp -r bin $out/share/fish/vendor_conf.d/
   '';
 
-  meta = with lib; {
+  meta = {
     description = "Utility tool powered by fzf for using git interactively";
     homepage = "https://github.com/wfxr/forgit";
-    license = licenses.mit;
-    maintainers = with maintainers; [ happysalada ];
+    license = lib.licenses.mit;
+    maintainers = with lib.maintainers; [ happysalada ];
   };
 }

pkgs/shells/fish/plugins/fzf-fish.nix

@@ -57,12 +57,12 @@ buildFishPlugin rec {
       ''script -c 'fish -c "fishtape tests/*/*.fish"' ''
   );
 
-  meta = with lib; {
+  meta = {
     description = "Augment your fish command line with fzf key bindings";
     homepage = "https://github.com/PatrickF1/fzf.fish";
     changelog = "https://github.com/PatrickF1/fzf.fish/releases/tag/${src.rev}";
-    license = licenses.mit;
-    maintainers = with maintainers; [
+    license = lib.licenses.mit;
+    maintainers = with lib.maintainers; [
       euxane
       natsukium
     ];

pkgs/shells/fish/plugins/fzf.nix

@@ -14,10 +14,10 @@ buildFishPlugin rec {
     sha256 = "sha256-28QW/WTLckR4lEfHv6dSotwkAKpNJFCShxmKFGQQ1Ew=";
   };
 
-  meta = with lib; {
+  meta = {
     description = "Ef-fish-ient fish keybindings for fzf";
     homepage = "https://github.com/jethrokuan/fzf";
-    license = licenses.mit;
-    maintainers = with maintainers; [ Scrumplex ];
+    license = lib.licenses.mit;
+    maintainers = with lib.maintainers; [ Scrumplex ];
   };
 }

pkgs/shells/fish/plugins/git-abbr.nix

@@ -14,10 +14,10 @@ buildFishPlugin {
     hash = "sha256-6z3Wr2t8CP85xVEp6UCYaM2KC9PX4MDyx19f/wjHkb0=";
   };
 
-  meta = with lib; {
+  meta = {
     description = "Abbreviations for git for the fish shell 🐟";
     homepage = "https://github.com/lewisacidic/fish-git-abbr";
-    license = licenses.mit;
-    maintainers = with maintainers; [ hmajid2301 ];
+    license = lib.licenses.mit;
+    maintainers = with lib.maintainers; [ hmajid2301 ];
   };
 }

pkgs/shells/fish/plugins/github-copilot-cli-fish.nix

@@ -15,10 +15,10 @@ buildFishPlugin rec {
     hash = "sha256-CFXbeO0euC/UtvQV0KCz4WQfdJgsuXKPM6M9oaw7hvg=";
   };
 
-  meta = with lib; {
+  meta = {
     description = "GitHub Copilot CLI aliases for Fish Shell";
     homepage = "https://github.com/z11i/github-copilot-cli.fish";
-    license = licenses.asl20;
-    maintainers = [ maintainers.malo ];
+    license = lib.licenses.asl20;
+    maintainers = [ lib.maintainers.malo ];
   };
 }

pkgs/shells/fish/plugins/grc.nix

@@ -19,10 +19,10 @@ buildFishPlugin {
     cp conf.d/executables $out/share/fish/vendor_conf.d/
   '';
 
-  meta = with lib; {
+  meta = {
     description = "Grc Colourizer for some commands on Fish shell";
-    license = licenses.mit;
-    maintainers = with maintainers; [ onny ];
-    platforms = with platforms; unix;
+    license = lib.licenses.mit;
+    maintainers = with lib.maintainers; [ onny ];
+    platforms = with lib.platforms; unix;
   };
 }

pkgs/shells/fish/plugins/humantime-fish.nix

@@ -20,10 +20,10 @@ buildFishPlugin {
     fishtape tests/humantime.fish
   '';
 
-  meta = with lib; {
+  meta = {
     description = "Turn milliseconds into a human-readable string in Fish";
     homepage = "https://github.com/jorgebucaran/humantime.fish";
-    license = licenses.mit;
-    maintainers = with maintainers; [ Scrumplex ];
+    license = lib.licenses.mit;
+    maintainers = with lib.maintainers; [ Scrumplex ];
   };
 }

pkgs/shells/fish/plugins/hydro.nix

@@ -15,10 +15,10 @@ buildFishPlugin {
     hash = "sha256-QYq4sU41/iKvDUczWLYRGqDQpVASF/+6brJJ8IxypjE=";
   };
 
-  meta = with lib; {
+  meta = {
     description = "Ultra-pure, lag-free prompt with async Git status";
     homepage = "https://github.com/jorgebucaran/hydro";
-    license = licenses.mit;
+    license = lib.licenses.mit;
     maintainers = [ ];
   };
 }

pkgs/shells/fish/plugins/pisces.nix

@@ -15,10 +15,10 @@ buildFishPlugin rec {
     sha256 = "sha256-Oou2IeNNAqR00ZT3bss/DbhrJjGeMsn9dBBYhgdafBw=";
   };
 
-  meta = with lib; {
+  meta = {
     description = "Paired symbols in the command line";
     homepage = "https://github.com/laughedelic/pisces";
-    license = licenses.lgpl3;
-    maintainers = with maintainers; [ vanilla ];
+    license = lib.licenses.lgpl3;
+    maintainers = with lib.maintainers; [ vanilla ];
   };
 }

pkgs/shells/fish/plugins/sdkman-for-fish.nix

@@ -15,10 +15,10 @@ buildFishPlugin rec {
     hash = "sha256-7cgyR3hQ30Jv+9lJS5qaBvSaI/0YVT8xPXlUhDBTdFc=";
   };
 
-  meta = with lib; {
+  meta = {
     description = "Adds support for SDKMAN! to fish";
     homepage = "https://github.com/reitzig/sdkman-for-fish";
-    license = licenses.mit;
-    maintainers = with maintainers; [ giorgiga ];
+    license = lib.licenses.mit;
+    maintainers = with lib.maintainers; [ giorgiga ];
   };
 }

pkgs/shells/fish/plugins/tide.nix

@@ -22,10 +22,10 @@ buildFishPlugin rec {
     cp -R functions/tide $out/share/fish/vendor_functions.d/
   '';
 
-  meta = with lib; {
+  meta = {
     description = "Ultimate Fish prompt";
     homepage = "https://github.com/IlanCosman/tide";
-    license = licenses.mit;
-    maintainers = [ maintainers.jocelynthode ];
+    license = lib.licenses.mit;
+    maintainers = [ lib.maintainers.jocelynthode ];
   };
 }

pkgs/shells/fish/plugins/transient-fish.nix

@@ -14,10 +14,10 @@ buildFishPlugin {
     hash = "sha256-rEkCimnkxcydKRI2y4DxEM7FD7F2/cGTZJN2Edq/Acc=";
   };
 
-  meta = with lib; {
+  meta = {
     description = "Fish plugin to enable a transient prompt";
     homepage = "https://github.com/zzhaolei/transient.fish";
-    license = licenses.mit;
-    maintainers = with maintainers; [ iynaix ];
+    license = lib.licenses.mit;
+    maintainers = with lib.maintainers; [ iynaix ];
   };
 }

pkgs/shells/fish/plugins/wakatime-fish.nix

@@ -22,10 +22,10 @@ buildFishPlugin rec {
       --replace-fail "(type -p wakatime)" "${lib.getExe wakatime-cli}"
   '';
 
-  meta = with lib; {
+  meta = {
     description = "Fish plugin for wakatime";
     homepage = "https://github.com/ik11235/wakatime.fish";
-    license = licenses.mit;
-    maintainers = with maintainers; [ ocfox ];
+    license = lib.licenses.mit;
+    maintainers = with lib.maintainers; [ ocfox ];
   };
 }

pkgs/shells/fish/plugins/z.nix

@@ -14,10 +14,10 @@ buildFishPlugin rec {
     sha256 = "sha256-+FUBM7CodtZrYKqU542fQD+ZDGrd2438trKM0tIESs0=";
   };
 
-  meta = with lib; {
+  meta = {
     description = "Pure-fish z directory jumping";
     homepage = "https://github.com/jethrokuan/z";
-    license = licenses.mit;
-    maintainers = with maintainers; [ Scrumplex ];
+    license = lib.licenses.mit;
+    maintainers = with lib.maintainers; [ Scrumplex ];
   };
 }

pkgs/shells/nushell/default.nix

@@ -95,11 +95,11 @@ rustPlatform.buildRustPackage {
     updateScript = nix-update-script { };
   };
 
-  meta = with lib; {
+  meta = {
     description = "Modern shell written in Rust";
     homepage = "https://www.nushell.sh/";
-    license = licenses.mit;
-    maintainers = with maintainers; [
+    license = lib.licenses.mit;
+    maintainers = with lib.maintainers; [
       johntitor
       joaquintrinanes
       ryan4yin