treewide: clean up 'meta = with' pattern

This commit was created by a combination of scripts and tools:
- an ast-grep script to prefix things in meta with `lib.`,
- a modified nixf-diagnose / nixf combination to remove unused `with
lib;`, and
- regular nixfmt.

Co-authored-by: Wolfgang Walther <walther@technowledgy.de>

pkgs/development/tools/continuous-integration/buildbot/master.nix

@@ -165,11 +165,11 @@ buildPythonApplication rec {
     };
   };
 
-  meta = with lib; {
+  meta = {
     description = "Open-source continuous integration framework for automating software build, test, and release processes";
     homepage = "https://buildbot.net/";
     changelog = "https://github.com/buildbot/buildbot/releases/tag/v${version}";
-    teams = [ teams.buildbot ];
-    license = licenses.gpl2Only;
+    teams = [ lib.teams.buildbot ];
+    license = lib.licenses.gpl2Only;
   };
 }

pkgs/development/tools/continuous-integration/buildbot/pkg.nix

@@ -24,10 +24,10 @@ buildPythonPackage {
 
   disabled = !isPy3k;
 
-  meta = with lib; {
+  meta = {
     homepage = "https://buildbot.net/";
     description = "Buildbot Packaging Helper";
-    teams = [ teams.buildbot ];
-    license = licenses.gpl2;
+    teams = [ lib.teams.buildbot ];
+    license = lib.licenses.gpl2;
   };
 }

pkgs/development/tools/continuous-integration/buildbot/plugins.nix

@@ -35,11 +35,11 @@
     # No tests
     doCheck = false;
 
-    meta = with lib; {
+    meta = {
       homepage = "https://buildbot.net/";
       description = "Buildbot UI";
-      teams = [ teams.buildbot ];
-      license = licenses.gpl2;
+      teams = [ lib.teams.buildbot ];
+      license = lib.licenses.gpl2;
     };
   };
 
@@ -58,11 +58,11 @@
     # No tests
     doCheck = false;
 
-    meta = with lib; {
+    meta = {
       homepage = "https://buildbot.net/";
       description = "Buildbot Console View Plugin";
-      teams = [ teams.buildbot ];
-      license = licenses.gpl2;
+      teams = [ lib.teams.buildbot ];
+      license = lib.licenses.gpl2;
     };
   };
 
@@ -81,11 +81,11 @@
     # No tests
     doCheck = false;
 
-    meta = with lib; {
+    meta = {
       homepage = "https://buildbot.net/";
       description = "Buildbot Waterfall View Plugin";
-      teams = [ teams.buildbot ];
-      license = licenses.gpl2;
+      teams = [ lib.teams.buildbot ];
+      license = lib.licenses.gpl2;
     };
   };
 
@@ -104,11 +104,11 @@
     # No tests
     doCheck = false;
 
-    meta = with lib; {
+    meta = {
       homepage = "https://buildbot.net/";
       description = "Buildbot Grid View Plugin";
-      teams = [ teams.buildbot ];
-      license = licenses.gpl2;
+      teams = [ lib.teams.buildbot ];
+      license = lib.licenses.gpl2;
     };
   };
 
@@ -127,11 +127,11 @@
     # No tests
     doCheck = false;
 
-    meta = with lib; {
+    meta = {
       homepage = "https://buildbot.net/";
       description = "Buildbot WSGI dashboards Plugin";
-      teams = [ teams.buildbot ];
-      license = licenses.gpl2;
+      teams = [ lib.teams.buildbot ];
+      license = lib.licenses.gpl2;
     };
   };
 
@@ -155,12 +155,12 @@
     # No tests
     doCheck = false;
 
-    meta = with lib; {
+    meta = {
       homepage = "https://buildbot.net/";
       description = "Buildbot Badges Plugin";
-      maintainers = [ maintainers.julienmalka ];
-      teams = [ teams.buildbot ];
-      license = licenses.gpl2;
+      maintainers = [ lib.maintainers.julienmalka ];
+      teams = [ lib.teams.buildbot ];
+      license = lib.licenses.gpl2;
     };
   };
 

pkgs/development/tools/continuous-integration/buildbot/worker.nix

@@ -52,10 +52,10 @@ buildPythonPackage {
     smoke-test = nixosTests.buildbot;
   };
 
-  meta = with lib; {
+  meta = {
     homepage = "https://buildbot.net/";
     description = "Buildbot Worker Daemon";
-    teams = [ teams.buildbot ];
-    license = licenses.gpl2;
+    teams = [ lib.teams.buildbot ];
+    license = lib.licenses.gpl2;
   };
 }

pkgs/development/tools/continuous-integration/buildkite-test-collector-rust/default.nix

@@ -20,11 +20,11 @@ rustPlatform.buildRustPackage rec {
 
   passthru.updateScript = nix-update-script { };
 
-  meta = with lib; {
+  meta = {
     description = "Rust adapter for Buildkite Test Analytics";
     mainProgram = "buildkite-test-collector";
     homepage = "https://buildkite.com/test-analytics";
-    license = with licenses; [ mit ];
-    maintainers = with maintainers; [ jfroche ];
+    license = with lib.licenses; [ mit ];
+    maintainers = with lib.maintainers; [ jfroche ];
   };
 }

pkgs/development/tools/continuous-integration/drone/default.nix

@@ -25,14 +25,14 @@ buildGoModule rec {
 
   doCheck = false;
 
-  meta = with lib; {
+  meta = {
     description = "Continuous Integration platform built on container technology";
     mainProgram = "drone-server";
     homepage = "https://github.com/harness/drone";
-    maintainers = with maintainers; [
+    maintainers = with lib.maintainers; [
       vdemeester
       techknowlogick
     ];
-    license = with licenses; if enableUnfree then unfreeRedistributable else asl20;
+    license = with lib.licenses; if enableUnfree then unfreeRedistributable else asl20;
   };
 }