From c3b7c6893e18f43f605addeae61e78ac78d67fb2 Mon Sep 17 00:00:00 2001 From: SandaruKasa Date: Fri, 26 Jun 2026 02:22:44 +0300 Subject: [PATCH 1/4] vlc: set `__structuredAttrs` --- pkgs/by-name/vl/vlc/package.nix | 2 ++ 1 file changed, 2 insertions(+) diff --git a/pkgs/by-name/vl/vlc/package.nix b/pkgs/by-name/vl/vlc/package.nix index 070f6c31eaac..379e9eb58068 100644 --- a/pkgs/by-name/vl/vlc/package.nix +++ b/pkgs/by-name/vl/vlc/package.nix @@ -219,7 +219,9 @@ stdenv.mkDerivation (finalAttrs: { ] ) ++ optionals (waylandSupport && withQt5) [ libsForQt5.qtwayland ]; + strictDeps = true; + __structuredAttrs = true; env = { # vlc searches for c11-gcc, c11, c99-gcc, c99, which don't exist and would be wrong for cross compilation anyway. From 89e99672a6f5883a8ac363f50e7043885a9e376e Mon Sep 17 00:00:00 2001 From: SandaruKasa Date: Fri, 26 Jun 2026 02:22:44 +0300 Subject: [PATCH 2/4] vlc: do not hardcode `gcc` compiler name --- pkgs/by-name/vl/vlc/package.nix | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkgs/by-name/vl/vlc/package.nix b/pkgs/by-name/vl/vlc/package.nix index 379e9eb58068..3a793ad7bb20 100644 --- a/pkgs/by-name/vl/vlc/package.nix +++ b/pkgs/by-name/vl/vlc/package.nix @@ -225,7 +225,7 @@ stdenv.mkDerivation (finalAttrs: { env = { # vlc searches for c11-gcc, c11, c99-gcc, c99, which don't exist and would be wrong for cross compilation anyway. - BUILDCC = "${pkgsBuildBuild.stdenv.cc}/bin/gcc"; + BUILDCC = lib.getExe pkgsBuildBuild.stdenv.cc; LIVE555_PREFIX = live555; } // lib.optionalAttrs stdenv.cc.isGNU { From c108cd98a60f957dba54d4a746ded23ce544f72f Mon Sep 17 00:00:00 2001 From: SandaruKasa Date: Fri, 26 Jun 2026 02:22:44 +0300 Subject: [PATCH 3/4] vlc: remove unneeded (and discouraged) `NIX_CFLAGS_COMPILE` --- pkgs/by-name/vl/vlc/package.nix | 3 --- 1 file changed, 3 deletions(-) diff --git a/pkgs/by-name/vl/vlc/package.nix b/pkgs/by-name/vl/vlc/package.nix index 3a793ad7bb20..53ed887c4836 100644 --- a/pkgs/by-name/vl/vlc/package.nix +++ b/pkgs/by-name/vl/vlc/package.nix @@ -227,9 +227,6 @@ stdenv.mkDerivation (finalAttrs: { # vlc searches for c11-gcc, c11, c99-gcc, c99, which don't exist and would be wrong for cross compilation anyway. BUILDCC = lib.getExe pkgsBuildBuild.stdenv.cc; LIVE555_PREFIX = live555; - } - // lib.optionalAttrs stdenv.cc.isGNU { - NIX_CFLAGS_COMPILE = "-Wno-error=incompatible-pointer-types"; }; patches = [ From 4f51698db982cac95bc7254b4aec0423698c1239 Mon Sep 17 00:00:00 2001 From: SandaruKasa Date: Fri, 26 Jun 2026 02:22:44 +0300 Subject: [PATCH 4/4] vlc: split outputs output size changes: - out: 70360K -> 68960K - dev: 0 -> 1152K - doc: 0 -> 252K - man: 0 -> 8K --- pkgs/by-name/vl/vlc/package.nix | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/pkgs/by-name/vl/vlc/package.nix b/pkgs/by-name/vl/vlc/package.nix index 53ed887c4836..9924f98000ee 100644 --- a/pkgs/by-name/vl/vlc/package.nix +++ b/pkgs/by-name/vl/vlc/package.nix @@ -223,6 +223,13 @@ stdenv.mkDerivation (finalAttrs: { strictDeps = true; __structuredAttrs = true; + outputs = [ + "out" + "dev" + "doc" + "man" + ]; + env = { # vlc searches for c11-gcc, c11, c99-gcc, c99, which don't exist and would be wrong for cross compilation anyway. BUILDCC = lib.getExe pkgsBuildBuild.stdenv.cc;