From 540e188796bfdb9580218f3be979a372023c27e7 Mon Sep 17 00:00:00 2001 From: Wolfgang Walther Date: Sat, 30 Aug 2025 15:24:13 +0200 Subject: [PATCH] ci/eval/compare: ping maintainers of removed packages This change pings maintainers of actually removed packages, aka where the package's expression is deleted. This will not ping maintainers of packages that become invisible, because a (transitive) dependency of them is marked as insecure or broken. --- ci/eval/compare/default.nix | 2 ++ ci/eval/compare/maintainers.nix | 3 ++- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/ci/eval/compare/default.nix b/ci/eval/compare/default.nix index 9060d357d662..b338d8f82d6d 100644 --- a/ci/eval/compare/default.nix +++ b/ci/eval/compare/default.nix @@ -78,6 +78,7 @@ let diffAttrs = builtins.fromJSON (builtins.readFile "${combinedDir}/combined-diff.json"); rebuildsPackagePlatformAttrs = convertToPackagePlatformAttrs diffAttrs.rebuilds; + removedPackagePlatformAttrs = convertToPackagePlatformAttrs diffAttrs.removed; changed-paths = let @@ -117,6 +118,7 @@ let maintainers = callPackage ./maintainers.nix { } { changedattrs = lib.attrNames (lib.groupBy (a: a.name) rebuildsPackagePlatformAttrs); changedpathsjson = touchedFilesJson; + removedattrs = lib.attrNames (lib.groupBy (a: a.name) removedPackagePlatformAttrs); inherit byName; }; in diff --git a/ci/eval/compare/maintainers.nix b/ci/eval/compare/maintainers.nix index 43ae050acba4..6c4be96dddbf 100644 --- a/ci/eval/compare/maintainers.nix +++ b/ci/eval/compare/maintainers.nix @@ -5,6 +5,7 @@ { changedattrs, changedpathsjson, + removedattrs, byName ? false, }: let @@ -24,7 +25,7 @@ let enrichedAttrs = builtins.map (name: { path = lib.splitString "." name; name = name; - }) changedattrs; + }) (changedattrs ++ removedattrs); validPackageAttributes = builtins.filter ( pkg: