From ed62714176e5dbb52ba80977f4b8e6a81bd11dc5 Mon Sep 17 00:00:00 2001
From: Gaetan Lepage <gaetan@glepage.com>
Date: Mon, 6 Jan 2025 13:29:12 +0100
Subject: [PATCH] python312Packages.jaxopt: disable failing tests

---
 .../python-modules/jaxopt/default.nix         | 30 ++++++++++++-------
 1 file changed, 19 insertions(+), 11 deletions(-)

diff --git a/pkgs/development/python-modules/jaxopt/default.nix b/pkgs/development/python-modules/jaxopt/default.nix
index 6d4c4a427444..211afb5ee57a 100644
--- a/pkgs/development/python-modules/jaxopt/default.nix
+++ b/pkgs/development/python-modules/jaxopt/default.nix
@@ -2,20 +2,24 @@
   lib,
   stdenv,
   buildPythonPackage,
-  pythonOlder,
   fetchFromGitHub,
   fetchpatch,
-  pytest-xdist,
-  pytestCheckHook,
+
+  # build-system
   setuptools,
+
+  # dependencies
   absl-py,
-  cvxpy,
   jax,
-  jaxlib,
   matplotlib,
   numpy,
-  optax,
   scipy,
+
+  # tests
+  cvxpy,
+  optax,
+  pytest-xdist,
+  pytestCheckHook,
   scikit-learn,
 }:
 
@@ -24,8 +28,6 @@ buildPythonPackage rec {
   version = "0.8.3";
   pyproject = true;
 
-  disabled = pythonOlder "3.8";
-
   src = fetchFromGitHub {
     owner = "google";
     repo = "jaxopt";
@@ -48,17 +50,16 @@ buildPythonPackage rec {
   dependencies = [
     absl-py
     jax
-    jaxlib
     matplotlib
     numpy
     scipy
   ];
 
   nativeCheckInputs = [
-    pytest-xdist
-    pytestCheckHook
     cvxpy
     optax
+    pytest-xdist
+    pytestCheckHook
     scikit-learn
   ];
 
@@ -74,6 +75,10 @@ buildPythonPackage rec {
     [
       # https://github.com/google/jaxopt/issues/592
       "test_solve_sparse"
+
+      # AssertionError: Not equal to tolerance rtol=1e-06, atol=1e-06
+      # https://github.com/google/jaxopt/issues/618
+      "test_binary_logit_log_likelihood"
     ]
     ++ lib.optionals (stdenv.hostPlatform.isLinux && stdenv.hostPlatform.isAarch64) [
       # https://github.com/google/jaxopt/issues/577
@@ -81,6 +86,9 @@ buildPythonPackage rec {
       "test_solve_sparse"
       "test_logreg_with_intercept_manual_loop3"
 
+      # Flaky (AssertionError)
+      "test_inv_hessian_product_pytree3"
+
       # https://github.com/google/jaxopt/issues/593
       # Makes the test suite crash
       "test_dtype_consistency"