From 52ec79a6382d7c20907e2226707950559db8e8e1 Mon Sep 17 00:00:00 2001
From: Fabian Affolter <mail@fabian-affolter.ch>
Date: Fri, 6 Sep 2024 16:58:35 +0200
Subject: [PATCH] python312Packages.howdoi: disable flaky tests

---
 .../python-modules/howdoi/default.nix         | 28 ++++++++++++++-----
 1 file changed, 21 insertions(+), 7 deletions(-)

diff --git a/pkgs/development/python-modules/howdoi/default.nix b/pkgs/development/python-modules/howdoi/default.nix
index db109c2f70ee..4a716b8b037b 100644
--- a/pkgs/development/python-modules/howdoi/default.nix
+++ b/pkgs/development/python-modules/howdoi/default.nix
@@ -15,19 +15,20 @@
   rich,
   pytestCheckHook,
   pythonOlder,
+  setuptools,
 }:
 
 buildPythonPackage rec {
   pname = "howdoi";
   version = "2.0.20";
-  format = "setuptools";
+  pyproject = true;
 
   disabled = pythonOlder "3.7";
 
   src = fetchFromGitHub {
     owner = "gleitz";
-    repo = pname;
-    rev = "v${version}";
+    repo = "howdoi";
+    rev = "refs/tags/v${version}";
     hash = "sha256-u0k+h7Sp2t/JUnfPqRzDpEA+vNXB7CpyZ/SRvk+B9t0=";
   };
 
@@ -37,11 +38,13 @@ buildPythonPackage rec {
     # Please remove on the next release
     (fetchpatch {
       url = "https://github.com/gleitz/howdoi/commit/7d24e9e1c87811a6e66d60f504381383cf1ac3fd.patch";
-      sha256 = "sha256-AFQMnMEijaExqiimbNaVeIRmZJ4Yj0nGUOEjfsvBLh8=";
+      hash = "sha256-AFQMnMEijaExqiimbNaVeIRmZJ4Yj0nGUOEjfsvBLh8=";
     })
   ];
 
-  propagatedBuildInputs = [
+  build-system = [ setuptools ];
+
+  dependencies = [
     appdirs
     cachelib
     colorama
@@ -60,14 +63,25 @@ buildPythonPackage rec {
     export HOME=$(mktemp -d)
   '';
 
-  disabledTests = [ "test_colorize" ];
+  disabledTests = [
+    "test_colorize"
+    # Tests are flaky, OSError: [Errno 24] Too many open files happpens
+    "test_answer_links_using_l_option"
+    "test_answers_bing"
+    "test_answers"
+    "test_json_output"
+    "test_missing_pre_or_code_query"
+    "test_multiple_answers"
+    "test_position"
+    "test_unicode_answer"
+  ];
 
   pythonImportsCheck = [ "howdoi" ];
 
   meta = with lib; {
-    changelog = "https://github.com/gleitz/howdoi/blob/v${version}/CHANGES.txt";
     description = "Instant coding answers via the command line";
     homepage = "https://github.com/gleitz/howdoi";
+    changelog = "https://github.com/gleitz/howdoi/blob/v${version}/CHANGES.txt";
     license = licenses.mit;
     maintainers = [ ];
   };