From 51666aeec351d1d57c5513e3d306458079b249aa Mon Sep 17 00:00:00 2001
From: Wael Nasreddine <wael.nasreddine@gmail.com>
Date: Mon, 2 Mar 2026 19:42:40 -0800
Subject: [PATCH] ncps: disable integration tests

The integration tests, albeit quite useful, can be flaky on slow and/or
busy systems (since they rely on wall clock to pass). For that reason, I
will disable them in nixpkgs and leave upstream to deal with testing it.
---
 pkgs/by-name/nc/ncps/package.nix | 31 -------------------------------
 1 file changed, 31 deletions(-)

diff --git a/pkgs/by-name/nc/ncps/package.nix b/pkgs/by-name/nc/ncps/package.nix
index 53e5602d51ca..61150c7b82c6 100644
--- a/pkgs/by-name/nc/ncps/package.nix
+++ b/pkgs/by-name/nc/ncps/package.nix
@@ -6,14 +6,9 @@
   jq,
   lib,
   makeWrapper,
-  mariadb,
-  minio,
-  minio-client,
   nix-update-script,
   nixosTests,
-  postgresql,
   python3,
-  redis,
   writeShellScriptBin,
   xz,
 }:
@@ -44,16 +39,7 @@ buildGoModule (finalAttrs: {
 
   nativeBuildInputs = [
     makeWrapper # used for wrapping the binary so it can always find the xz binary
-
-    curl # used for checking MinIO health check
     dbmate # used for testing
-    jq # used for testing by the init-minio
-    mariadb # MySQL/MariaDB for integration tests
-    minio # S3-compatible storage for integration tests
-    minio-client # mc CLI for MinIO setup
-    postgresql # PostgreSQL for integration tests
-    python3 # used for generating the ports
-    redis # Redis for distributed locking integration tests
   ];
 
   postInstall = ''
@@ -78,23 +64,6 @@ buildGoModule (finalAttrs: {
 
   checkFlags = [ "-race" ];
 
-  # pre and post checks
-  preCheck = ''
-    # Set up cleanup trap to ensure background processes are killed even if tests fail
-    cleanup() {
-      source $src/nix/packages/ncps/post-check-minio.sh
-      source $src/nix/packages/ncps/post-check-mysql.sh
-      source $src/nix/packages/ncps/post-check-postgres.sh
-      source $src/nix/packages/ncps/post-check-redis.sh
-    }
-    trap cleanup EXIT
-
-    source $src/nix/packages/ncps/pre-check-minio.sh
-    source $src/nix/packages/ncps/pre-check-mysql.sh
-    source $src/nix/packages/ncps/pre-check-postgres.sh
-    source $src/nix/packages/ncps/pre-check-redis.sh
-  '';
-
   passthru = {
     dbmate-wrapper = buildGoModule {
       pname = "ncps-dbmate-wrapper";