From 868ae9a62f97dcb18d967e4816422f2e68306da9 Mon Sep 17 00:00:00 2001 From: phanirithvij Date: Mon, 2 Dec 2024 12:20:04 +0530 Subject: [PATCH 1/2] lazygit: use go1.22 Regression in go1.23 see https://github.com/jesseduffield/lazygit/issues/4002 Signed-off-by: phanirithvij --- pkgs/by-name/la/lazygit/package.nix | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/pkgs/by-name/la/lazygit/package.nix b/pkgs/by-name/la/lazygit/package.nix index d1fcbdcc7b0e..54ac4b57d9ea 100644 --- a/pkgs/by-name/la/lazygit/package.nix +++ b/pkgs/by-name/la/lazygit/package.nix @@ -1,11 +1,12 @@ { lib, - buildGoModule, + buildGo122Module, fetchFromGitHub, lazygit, testers, }: -buildGoModule rec { +# Regression in go1.23 see https://github.com/jesseduffield/lazygit/issues/4002 +buildGo122Module rec { pname = "lazygit"; version = "0.44.1"; From a5291b34f8b5a99c30d9eb002eaf258ed453caed Mon Sep 17 00:00:00 2001 From: phanirithvij Date: Mon, 2 Dec 2024 21:14:53 +0530 Subject: [PATCH 2/2] lazygit: remove with lib Signed-off-by: phanirithvij --- pkgs/by-name/la/lazygit/package.nix | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/pkgs/by-name/la/lazygit/package.nix b/pkgs/by-name/la/lazygit/package.nix index 54ac4b57d9ea..f8f1f886889d 100644 --- a/pkgs/by-name/la/lazygit/package.nix +++ b/pkgs/by-name/la/lazygit/package.nix @@ -13,7 +13,7 @@ buildGo122Module rec { src = fetchFromGitHub { owner = "jesseduffield"; repo = pname; - rev = "v${version}"; + rev = "refs/tags/v${version}"; hash = "sha256-BP5PMgRq8LHLuUYDrWaX1PgfT9VEhj3xeLE2aDMAPF0="; }; @@ -27,12 +27,12 @@ buildGo122Module rec { passthru.tests.version = testers.testVersion { package = lazygit; }; - meta = with lib; { + meta = { description = "Simple terminal UI for git commands"; homepage = "https://github.com/jesseduffield/lazygit"; changelog = "https://github.com/jesseduffield/lazygit/releases/tag/v${version}"; - license = licenses.mit; - maintainers = with maintainers; [ + license = lib.licenses.mit; + maintainers = with lib.maintainers; [ Br1ght0ne equirosa khaneliman