From 6ba20fc4228ce1b3e2e9c9f47896fa012918456c Mon Sep 17 00:00:00 2001 From: t4ccer Date: Mon, 15 Jul 2024 12:04:38 -0600 Subject: [PATCH] opencomposite: fix build --- pkgs/by-name/op/opencomposite/package.nix | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/pkgs/by-name/op/opencomposite/package.nix b/pkgs/by-name/op/opencomposite/package.nix index 40bc6f785839..cc9929d392ba 100644 --- a/pkgs/by-name/op/opencomposite/package.nix +++ b/pkgs/by-name/op/opencomposite/package.nix @@ -43,11 +43,17 @@ stdenv.mkDerivation { cmakeFlags = [ (lib.cmakeBool "USE_SYSTEM_OPENXR" true) (lib.cmakeBool "USE_SYSTEM_GLM" true) - (lib.cmakeFeature "CMAKE_CXX_FLAGS" "-DGLM_ENABLE_EXPERIMENTAL") - # debug logging macros cause format-security warnings - (lib.cmakeFeature "CMAKE_CXX_FLAGS" "-Wno-error=format-security") ]; + # NOTE: `cmakeFlags` will get later tokenized by bash and there is no way + # of inserting a flag value with a space in it (inserting `"` or `'` won't help). + # https://discourse.nixos.org/t/cmakeflags-and-spaces-in-option-values/20170/2 + preConfigure = '' + cmakeFlagsArray+=( + "-DCMAKE_CXX_FLAGS=-DGLM_ENABLE_EXPERIMENTAL -Wno-error=format-security" + ) + ''; + installPhase = '' runHook preInstall mkdir -p $out/lib/opencomposite