From f732cddf3d7089d2f6ce1625a6ba5cf20bf5ca8d Mon Sep 17 00:00:00 2001 From: Pol Dellaiera Date: Thu, 25 Sep 2025 21:50:52 +0200 Subject: [PATCH 1/5] tomb: add missing phase hooks --- pkgs/by-name/to/tomb/package.nix | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/pkgs/by-name/to/tomb/package.nix b/pkgs/by-name/to/tomb/package.nix index 171751e5f84f..4af247624d18 100644 --- a/pkgs/by-name/to/tomb/package.nix +++ b/pkgs/by-name/to/tomb/package.nix @@ -69,11 +69,15 @@ stdenvNoCC.mkDerivation (finalAttrs: { ''; installPhase = '' + runHook preInstall + install -Dm755 tomb $out/bin/tomb install -Dm644 doc/tomb.1 $out/share/man/man1/tomb.1 wrapProgram $out/bin/tomb \ --prefix PATH : $out/bin:${lib.makeBinPath runtimeDependencies} + + runHook postInstall ''; passthru = { From 0c6a587b9e8e77d8e866d1ad232559cdf39594ed Mon Sep 17 00:00:00 2001 From: Pol Dellaiera Date: Thu, 25 Sep 2025 21:52:00 +0200 Subject: [PATCH 2/5] tomb: use `versionCheckHook` --- pkgs/by-name/to/tomb/package.nix | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/pkgs/by-name/to/tomb/package.nix b/pkgs/by-name/to/tomb/package.nix index 4af247624d18..aea8b2922474 100644 --- a/pkgs/by-name/to/tomb/package.nix +++ b/pkgs/by-name/to/tomb/package.nix @@ -17,8 +17,8 @@ nix-update-script, pinentry, stdenvNoCC, - testers, util-linux, + versionCheckHook, zsh, }: @@ -80,11 +80,11 @@ stdenvNoCC.mkDerivation (finalAttrs: { runHook postInstall ''; + doInstallCheck = true; + nativeInstallCheckInputs = [ versionCheckHook ]; + versionCheckProgramArg = "-v"; + passthru = { - tests.version = testers.testVersion { - package = finalAttrs.finalPackage; - command = "tomb -v"; - }; updateScript = nix-update-script { }; }; From 03ba08102b6aba9e9b9bbaf6a4f9c7147c269e8c Mon Sep 17 00:00:00 2001 From: Pol Dellaiera Date: Thu, 25 Sep 2025 21:53:44 +0200 Subject: [PATCH 3/5] tomb: use `makeBinaryWrapper` --- pkgs/by-name/to/tomb/package.nix | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkgs/by-name/to/tomb/package.nix b/pkgs/by-name/to/tomb/package.nix index aea8b2922474..ffce2e543906 100644 --- a/pkgs/by-name/to/tomb/package.nix +++ b/pkgs/by-name/to/tomb/package.nix @@ -13,7 +13,7 @@ lib, libargon2, lsof, - makeWrapper, + makeBinaryWrapper, nix-update-script, pinentry, stdenvNoCC, @@ -52,7 +52,7 @@ stdenvNoCC.mkDerivation (finalAttrs: { hash = "sha256-z7LkCes0wg+1bZrNXXy4Lh5VwMotCULJQy5DmCisu+Q="; }; - nativeBuildInputs = [ makeWrapper ]; + nativeBuildInputs = [ makeBinaryWrapper ]; buildInputs = [ pinentry From d3cd37e8912514b6767f9ef3ee30be737402fdc9 Mon Sep 17 00:00:00 2001 From: Pol Dellaiera Date: Thu, 25 Sep 2025 22:00:44 +0200 Subject: [PATCH 4/5] tomb: update `install` commands in `installPhase` --- pkgs/by-name/to/tomb/package.nix | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkgs/by-name/to/tomb/package.nix b/pkgs/by-name/to/tomb/package.nix index ffce2e543906..266e19601dd2 100644 --- a/pkgs/by-name/to/tomb/package.nix +++ b/pkgs/by-name/to/tomb/package.nix @@ -71,8 +71,8 @@ stdenvNoCC.mkDerivation (finalAttrs: { installPhase = '' runHook preInstall - install -Dm755 tomb $out/bin/tomb - install -Dm644 doc/tomb.1 $out/share/man/man1/tomb.1 + install -D -m755 -t $out/bin tomb + install -D -m644 -t $out/share/man/man1/ doc/tomb.1 wrapProgram $out/bin/tomb \ --prefix PATH : $out/bin:${lib.makeBinPath runtimeDependencies} From 46753fc9d6ffde1ee338b048e2a37b293f274a87 Mon Sep 17 00:00:00 2001 From: Pol Dellaiera Date: Thu, 25 Sep 2025 22:17:26 +0200 Subject: [PATCH 5/5] tomb: use `util-linuxMinimal` --- pkgs/by-name/to/tomb/package.nix | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkgs/by-name/to/tomb/package.nix b/pkgs/by-name/to/tomb/package.nix index 266e19601dd2..1ebfad7df23d 100644 --- a/pkgs/by-name/to/tomb/package.nix +++ b/pkgs/by-name/to/tomb/package.nix @@ -17,7 +17,7 @@ nix-update-script, pinentry, stdenvNoCC, - util-linux, + util-linuxMinimal, versionCheckHook, zsh, }: @@ -37,7 +37,7 @@ let libargon2 lsof pinentry - util-linux + util-linuxMinimal ]; in