From 4b623fa2b84721dfacfa603a8f4d0489fba954fa Mon Sep 17 00:00:00 2001 From: Eman Resu <78693624+quatquatt@users.noreply.github.com> Date: Sun, 21 Jun 2026 18:46:26 -0400 Subject: [PATCH] lib.lists.reverseList: avoid subtraction --- lib/lists.nix | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/lists.nix b/lib/lists.nix index 9863c064426d..a5ee7c5a880d 100644 --- a/lib/lists.nix +++ b/lib/lists.nix @@ -1125,9 +1125,10 @@ rec { reverseList = xs: let - l = length xs; + # subtract one to save an __sub call on every element + lastIndex = length xs - 1; in - genList (n: elemAt xs (l - n - 1)) l; + genList (n: elemAt xs (lastIndex - n)) (lastIndex + 1); /** Depth-First Search (DFS) for lists `list != []`.