From 4af3b807fccfddfceb4aad422018a5f9e8cdb8a0 Mon Sep 17 00:00:00 2001 From: nicoo Date: Sun, 12 May 2024 13:48:23 +0000 Subject: [PATCH] testers.hasPkgConfigModules: fix `versionCheck` conditional Broke tests, as the version check was effectively always enabled: https://github.com/NixOS/nixpkgs/pull/307770#issuecomment-2102586718 --- pkgs/build-support/testers/hasPkgConfigModules/tester.nix | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkgs/build-support/testers/hasPkgConfigModules/tester.nix b/pkgs/build-support/testers/hasPkgConfigModules/tester.nix index b8ae884ba7b0..6a09255bde6c 100644 --- a/pkgs/build-support/testers/hasPkgConfigModules/tester.nix +++ b/pkgs/build-support/testers/hasPkgConfigModules/tester.nix @@ -55,7 +55,7 @@ runCommand testName { fi done - if [[ $notFound -eq 0 ]] && ([[ $versionMismatch -eq 0 ]] || [[ "$versionCheck" == false ]]); then + if [[ $notFound -eq 0 ]] && ([[ $versionMismatch -eq 0 ]] || [[ -z "$versionCheck" ]]); then exit 0 fi if [[ $notFound -ne 0 ]]; then