From 4a37c33e290eb3ad133d65738b874f728ba60776 Mon Sep 17 00:00:00 2001 From: Thomas FitzGerald Date: Mon, 16 Feb 2026 04:04:27 -0500 Subject: [PATCH] zed-editor: fix darwin build by appending buildFeatures to checkFeatures For the same reason runtime_shaders is passed to buildFeatures, it must also be passed to checkFeatures to avoid fallback to proprietary Metal shaders not available in Nix sandbox. Co-authored-by: Niklas Korz --- pkgs/by-name/ze/zed-editor/package.nix | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/pkgs/by-name/ze/zed-editor/package.nix b/pkgs/by-name/ze/zed-editor/package.nix index 3a1aa5284eb8..3da7c6df7cdb 100644 --- a/pkgs/by-name/ze/zed-editor/package.nix +++ b/pkgs/by-name/ze/zed-editor/package.nix @@ -196,7 +196,12 @@ rustPlatform.buildRustPackage (finalAttrs: { # Some crates define extra types or enum values in test configuration which then lead # to type checking errors in other crates unless this feature is enabled. - checkFeatures = [ "visual-tests" ]; + # gpui/runtime_shaders is required on darwin for the same reason as buildFeatures above: + # without it, build.rs invokes the proprietary Metal shader compiler. + checkFeatures = [ + "visual-tests" + ] + ++ finalAttrs.buildFeatures; env = { ALLOW_MISSING_LICENSES = true;