From 4725dfecf6e987d32d5035e93abb2299653bb72d Mon Sep 17 00:00:00 2001 From: Jon Roberts Date: Wed, 29 Sep 2021 22:57:05 -0500 Subject: [PATCH] google-java-format: fix for jdk 16 JDK 16 requires some extra flags to actually format code: https://github.com/google/google-java-format#jdk-16 --- .../tools/google-java-format/default.nix | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/pkgs/development/tools/google-java-format/default.nix b/pkgs/development/tools/google-java-format/default.nix index 626a3b5271d0..0d939760760c 100644 --- a/pkgs/development/tools/google-java-format/default.nix +++ b/pkgs/development/tools/google-java-format/default.nix @@ -17,11 +17,17 @@ stdenv.mkDerivation rec { installPhase = '' runHook preInstall - mkdir -p $out/{bin,share/google-java-format} - install -D ${src} $out/share/google-java-format/google-java-format.jar + mkdir -p $out/{bin,share/${pname}} + install -D ${src} $out/share/${pname}/google-java-format-${version}-all-deps.jar - makeWrapper ${jre}/bin/java $out/bin/google-java-format \ - --add-flags "-jar $out/share/google-java-format/google-java-format.jar" + makeWrapper ${jre}/bin/java $out/bin/${pname} \ + --argv0 ${pname} \ + --add-flags "--add-exports jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED" \ + --add-flags "--add-exports jdk.compiler/com.sun.tools.javac.file=ALL-UNNAMED" \ + --add-flags "--add-exports jdk.compiler/com.sun.tools.javac.parser=ALL-UNNAMED" \ + --add-flags "--add-exports jdk.compiler/com.sun.tools.javac.tree=ALL-UNNAMED" \ + --add-flags "--add-exports jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED" \ + --add-flags "-jar $out/share/${pname}/google-java-format-${version}-all-deps.jar" runHook postInstall '';