From 46a9d23d5486e4b85a6b65d690d55bfa5b0778e6 Mon Sep 17 00:00:00 2001 From: Mitchell Skaggs Date: Wed, 4 Mar 2026 20:02:45 -0600 Subject: [PATCH] {mumble, murmur}: fix build with Protobuf 34 Protobuf 34 has a breaking change: https://github.com/protocolbuffers/protobuf/commit/10af44bb0b8e2428b072c06ca0cee7ff0b38c624 --- pkgs/applications/networking/mumble/default.nix | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkgs/applications/networking/mumble/default.nix b/pkgs/applications/networking/mumble/default.nix index 5628ada5a507..50759da2fd1a 100644 --- a/pkgs/applications/networking/mumble/default.nix +++ b/pkgs/applications/networking/mumble/default.nix @@ -2,7 +2,6 @@ lib, stdenv, fetchFromGitHub, - fetchpatch, pkg-config, qt5, cmake, @@ -78,6 +77,7 @@ let "-D CMAKE_UNITY_BUILD=ON" # Upstream uses this in their build pipeline to speed up builds "-D bundled-gsl=OFF" "-D bundled-json=OFF" + "-D warnings-as-errors=OFF" # protobuf 34.x `[[nodiscard]]` workaround https://github.com/mumble-voip/mumble/issues/7102 ] ++ (overrides.cmakeFlags or [ ]); @@ -136,7 +136,7 @@ let "-D update=OFF" "-D overlay-xcompile=OFF" "-D oss=OFF" - "-D warnings-as-errors=OFF" # conversion error workaround + "-D warnings-as-errors=OFF" # `std::wstring_convert` deprecation workaround # building the overlay on darwin does not work in nipxkgs (yet) # also see the patch below to disable scripts the build option misses # see https://github.com/mumble-voip/mumble/issues/6816