From 2da15b58ab4ad908b93bdc972f747cb07d5782f7 Mon Sep 17 00:00:00 2001 From: Piotr Kwiecinski <2151333+piotrkwiecinski@users.noreply.github.com> Date: Tue, 3 Feb 2026 14:48:46 +0100 Subject: [PATCH 1/4] frankenphp: update github owner --- pkgs/by-name/fr/frankenphp/package.nix | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pkgs/by-name/fr/frankenphp/package.nix b/pkgs/by-name/fr/frankenphp/package.nix index 12eec85f538a..6f59da486813 100644 --- a/pkgs/by-name/fr/frankenphp/package.nix +++ b/pkgs/by-name/fr/frankenphp/package.nix @@ -34,7 +34,7 @@ buildGoModule rec { version = "1.11.1"; src = fetchFromGitHub { - owner = "dunglas"; + owner = "php"; repo = "frankenphp"; tag = "v${version}"; hash = "sha256-JzZXg/tkSZqLZn56RyLb8Q8SaeG/tHA8Sqxu99s5ks0="; @@ -126,9 +126,9 @@ buildGoModule rec { }; meta = { - changelog = "https://github.com/dunglas/frankenphp/releases/tag/v${version}"; + changelog = "https://github.com/php/frankenphp/releases/tag/v${version}"; description = "Modern PHP app server"; - homepage = "https://github.com/dunglas/frankenphp"; + homepage = "https://github.com/php/frankenphp"; license = lib.licenses.mit; mainProgram = "frankenphp"; maintainers = [ ]; From 626b549aecea280145d3ed52a6508a1b06a9a183 Mon Sep 17 00:00:00 2001 From: Piotr Kwiecinski <2151333+piotrkwiecinski@users.noreply.github.com> Date: Tue, 3 Feb 2026 14:50:15 +0100 Subject: [PATCH 2/4] frankenphp: add versionCheckHook --- pkgs/by-name/fr/frankenphp/package.nix | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/pkgs/by-name/fr/frankenphp/package.nix b/pkgs/by-name/fr/frankenphp/package.nix index 6f59da486813..2d19f7530310 100644 --- a/pkgs/by-name/fr/frankenphp/package.nix +++ b/pkgs/by-name/fr/frankenphp/package.nix @@ -6,7 +6,6 @@ php, brotli, watcher, - testers, frankenphp, cctools, darwin, @@ -15,6 +14,7 @@ makeBinaryWrapper, runCommand, writeText, + versionCheckHook, }: let @@ -103,15 +103,14 @@ buildGoModule rec { doCheck = false; + nativeInstallCheckInputs = [ versionCheckHook ]; + versionCheckProgramArg = "version"; + doInstallCheck = true; + passthru = { php = phpEmbedWithZts; tests = { # TODO: real NixOS test with Symfony application - version = testers.testVersion { - inherit version; - package = frankenphp; - command = "frankenphp version"; - }; phpinfo = runCommand "php-cli-phpinfo" { From aba0461602c8123d1ac2a3e74c9e525b26defc72 Mon Sep 17 00:00:00 2001 From: Piotr Kwiecinski <2151333+piotrkwiecinski@users.noreply.github.com> Date: Tue, 3 Feb 2026 14:53:01 +0100 Subject: [PATCH 3/4] frankenphp: add piotrkwiecinski as maintainer --- pkgs/by-name/fr/frankenphp/package.nix | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkgs/by-name/fr/frankenphp/package.nix b/pkgs/by-name/fr/frankenphp/package.nix index 2d19f7530310..4d8ae231a29d 100644 --- a/pkgs/by-name/fr/frankenphp/package.nix +++ b/pkgs/by-name/fr/frankenphp/package.nix @@ -130,7 +130,7 @@ buildGoModule rec { homepage = "https://github.com/php/frankenphp"; license = lib.licenses.mit; mainProgram = "frankenphp"; - maintainers = [ ]; + maintainers = [ lib.maintainers.piotrkwiecinski ]; platforms = lib.platforms.linux ++ lib.platforms.darwin; }; } From 6c7cbd8a3c24c25b8f067e04d5d665b9cc06dedb Mon Sep 17 00:00:00 2001 From: Piotr Kwiecinski <2151333+piotrkwiecinski@users.noreply.github.com> Date: Tue, 3 Feb 2026 15:12:19 +0100 Subject: [PATCH 4/4] frankenphp: remove no longer needed homebrew substitute --- pkgs/by-name/fr/frankenphp/package.nix | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/pkgs/by-name/fr/frankenphp/package.nix b/pkgs/by-name/fr/frankenphp/package.nix index 4d8ae231a29d..6d2578e3cf39 100644 --- a/pkgs/by-name/fr/frankenphp/package.nix +++ b/pkgs/by-name/fr/frankenphp/package.nix @@ -60,6 +60,7 @@ buildGoModule rec { pkg-config cctools darwin.autoSignDarwinBinariesHook + libiconv ]; subPackages = [ "frankenphp" ]; @@ -87,11 +88,6 @@ buildGoModule rec { export CGO_LDFLAGS="-DFRANKENPHP_VERSION=${version} \ $(${phpConfig} --ldflags) \ $(${phpConfig} --libs)" - '' - + lib.optionalString stdenv.hostPlatform.isDarwin '' - # replace hard-code homebrew path - substituteInPlace ../frankenphp.go \ - --replace "-L/opt/homebrew/opt/libiconv/lib" "-L${libiconv}/lib" ''; preFixup = ''