From c70a7f9fe95bd6eed4933113e7e9a20c9a1bcf8a Mon Sep 17 00:00:00 2001 From: Mikael Fangel <34864484+MikaelFangel@users.noreply.github.com> Date: Sat, 21 Oct 2023 21:31:23 +0200 Subject: [PATCH 1/6] nwjs: 0.54.1 -> 0.82.0 --- pkgs/development/tools/nwjs/default.nix | 22 ++++++++++------------ 1 file changed, 10 insertions(+), 12 deletions(-) diff --git a/pkgs/development/tools/nwjs/default.nix b/pkgs/development/tools/nwjs/default.nix index dd3d9cf6faaf..9a87110497f0 100644 --- a/pkgs/development/tools/nwjs/default.nix +++ b/pkgs/development/tools/nwjs/default.nix @@ -1,4 +1,4 @@ -{ stdenv, lib, fetchurl, buildEnv, makeWrapper +{ stdenv, lib, fetchurl, buildEnv, makeWrapper, autoPatchelfHook , xorg, alsa-lib, at-spi2-core, dbus, glib, gtk3, atk, pango, freetype , fontconfig , gdk-pixbuf, cairo, mesa, nss, nspr, expat, systemd @@ -35,22 +35,22 @@ let in stdenv.mkDerivation rec { pname = "nwjs"; - version = "0.54.1"; + version = "0.82.0"; src = if sdk then fetchurl { url = "https://dl.nwjs.io/v${version}/nwjs-sdk-v${version}-linux-${bits}.tar.gz"; - sha256 = if bits == "x64" then - "sha256-1qeU4+EIki0M7yJPkRuzFwMdswfDOni5gltdmM6A/ds=" else - "sha256-wDEGePE9lrKa6OAzeiDLhVj992c0TJgiMHb8lJ4PF80="; + hash = if bits == "x64" then + "sha256-rKbnNAq9AVjSUjTipYze2VHiVi0RnZZsdQj1725DPd0=" else + "sha256-aIRnZDslOhoD5F0coX43VNFWGEImPU5oq9Roc4jYfsY="; } else fetchurl { url = "https://dl.nwjs.io/v${version}/nwjs-v${version}-linux-${bits}.tar.gz"; - sha256 = if bits == "x64" then - "sha256-TACEM06K2t6dDXRD44lSW7GRi77yzSW4BZJw8gT+fl4=" else - "sha256-yX9knqFV5VQTT3TJDmQoDgt17NqH8fLt+bLQAqKleTU="; + hash = if bits == "x64" then + "sha256-aIRnZDslOhoD5F0coX43VNFWGEImPU5oq9Roc4jYfsY=" else + "sha256-pA53+A+EtS7m6026jPlC3vFxb2iheS4peDJFNkQAf/s="; }; - # we have runtime deps like sqlite3 that should remain - dontPatchELF = true; + nativeBuildInputs = [ makeWrapper autoPatchelfHook ]; + runtimeDependencies = [ sqlite libuuid udev ]; installPhase = let ccPath = lib.makeLibraryPath [ stdenv.cc.cc ]; @@ -86,8 +86,6 @@ in stdenv.mkDerivation rec { ln -s $out/share/nwjs/lib/libnw.so $out/lib/libnw.so ''; - nativeBuildInputs = [ makeWrapper ]; - meta = with lib; { description = "An app runtime based on Chromium and node.js"; homepage = "https://nwjs.io/"; From 3fdf3742bacab4cdd69e583606a92f7f7a8986d9 Mon Sep 17 00:00:00 2001 From: Mikael Fangel <34864484+MikaelFangel@users.noreply.github.com> Date: Mon, 6 Nov 2023 14:03:02 +0100 Subject: [PATCH 2/6] nwjs: format file --- pkgs/development/tools/nwjs/default.nix | 117 +++++++++++++++++------- 1 file changed, 85 insertions(+), 32 deletions(-) diff --git a/pkgs/development/tools/nwjs/default.nix b/pkgs/development/tools/nwjs/default.nix index 9a87110497f0..56cce99d7222 100644 --- a/pkgs/development/tools/nwjs/default.nix +++ b/pkgs/development/tools/nwjs/default.nix @@ -1,60 +1,113 @@ -{ stdenv, lib, fetchurl, buildEnv, makeWrapper, autoPatchelfHook - -, xorg, alsa-lib, at-spi2-core, dbus, glib, gtk3, atk, pango, freetype -, fontconfig , gdk-pixbuf, cairo, mesa, nss, nspr, expat, systemd -, libcap, libdrm, libxkbcommon +{ alsa-lib +, at-spi2-core +, atk +, autoPatchelfHook +, buildEnv +, cairo +, cups +, dbus +, expat +, fetchurl +, ffmpeg +, fontconfig +, freetype +, gdk-pixbuf +, glib +, gtk3 +, lib +, libcap +, libdrm , libnotify -, ffmpeg, libxcb, cups -, sqlite, udev , libuuid +, libxcb +, libxkbcommon +, makeWrapper +, mesa +, nspr +, nss +, pango , sdk ? false +, sqlite +, stdenv +, systemd +, udev +, xorg }: + let - bits = if stdenv.hostPlatform.system == "x86_64-linux" then "x64" - else "ia32"; + bits = if stdenv.hostPlatform.system == "x86_64-linux" then "x64" else "ia32"; nwEnv = buildEnv { name = "nwjs-env"; paths = [ - xorg.libX11 xorg.libXrender glib gtk3 atk at-spi2-core pango cairo gdk-pixbuf - freetype fontconfig xorg.libXcomposite alsa-lib xorg.libXdamage - xorg.libXext xorg.libXfixes mesa nss nspr expat dbus - xorg.libXtst xorg.libXi xorg.libXcursor xorg.libXrandr - xorg.libXScrnSaver xorg.libxshmfence cups - libcap libdrm libnotify + alsa-lib + at-spi2-core + atk + cairo + cups + dbus + expat + fontconfig + freetype + gdk-pixbuf + glib + gtk3 + libcap + libdrm + libnotify libxkbcommon + mesa + nspr + nss + pango + xorg.libX11 + xorg.libXScrnSaver + xorg.libXcomposite + xorg.libXcursor + xorg.libXdamage + xorg.libXext + xorg.libXfixes + xorg.libXi + xorg.libXrandr + xorg.libXrender + xorg.libXtst + xorg.libxshmfence # libnw-specific (not chromium dependencies) - ffmpeg libxcb + ffmpeg + libxcb # chromium runtime deps (dlopen’d) - sqlite udev libuuid + sqlite + udev ]; extraOutputsToInstall = [ "lib" "out" ]; }; -in stdenv.mkDerivation rec { +in +stdenv.mkDerivation rec { pname = "nwjs"; version = "0.82.0"; - src = if sdk then fetchurl { - url = "https://dl.nwjs.io/v${version}/nwjs-sdk-v${version}-linux-${bits}.tar.gz"; - hash = if bits == "x64" then - "sha256-rKbnNAq9AVjSUjTipYze2VHiVi0RnZZsdQj1725DPd0=" else - "sha256-aIRnZDslOhoD5F0coX43VNFWGEImPU5oq9Roc4jYfsY="; - } else fetchurl { - url = "https://dl.nwjs.io/v${version}/nwjs-v${version}-linux-${bits}.tar.gz"; - hash = if bits == "x64" then - "sha256-aIRnZDslOhoD5F0coX43VNFWGEImPU5oq9Roc4jYfsY=" else - "sha256-pA53+A+EtS7m6026jPlC3vFxb2iheS4peDJFNkQAf/s="; - }; + src = + let flavor = if sdk then "sdk-" else ""; + in fetchurl { + url = "https://dl.nwjs.io/v${version}/nwjs-${flavor}v${version}-linux-${bits}.tar.gz"; + hash = { + "sdk-ia32" = "sha256-aIRnZDslOhoD5F0coX43VNFWGEImPU5oq9Roc4jYfsY="; + "sdk-x64" = "sha256-rKbnNAq9AVjSUjTipYze2VHiVi0RnZZsdQj1725DPd0="; + "ia32" = "sha256-pA53+A+EtS7m6026jPlC3vFxb2iheS4peDJFNkQAf/s="; + "x64" = "sha256-hRih8o8hBbYBEes3Z62PSMIC720SLRa3t2rL/5LaJAE="; + }."${flavor + bits}"; + }; nativeBuildInputs = [ makeWrapper autoPatchelfHook ]; runtimeDependencies = [ sqlite libuuid udev ]; installPhase = let ccPath = lib.makeLibraryPath [ stdenv.cc.cc ]; - in '' + in + '' mkdir -p $out/share/nwjs cp -R * $out/share/nwjs find $out/share/nwjs @@ -84,12 +137,12 @@ in stdenv.mkDerivation rec { mkdir $out/lib ln -s $out/share/nwjs/lib/libnw.so $out/lib/libnw.so - ''; + ''; meta = with lib; { description = "An app runtime based on Chromium and node.js"; homepage = "https://nwjs.io/"; - platforms = ["i686-linux" "x86_64-linux"]; + platforms = [ "i686-linux" "x86_64-linux" ]; maintainers = [ maintainers.offline ]; license = licenses.bsd3; }; From 52c2996076cbf3ef8209024c23b983f9d85903ea Mon Sep 17 00:00:00 2001 From: Mikael Fangel <34864484+MikaelFangel@users.noreply.github.com> Date: Mon, 6 Nov 2023 14:04:27 +0100 Subject: [PATCH 3/6] nwjs: go all in with autoPatchelfHook Co-authored-by: robert manchester <86313040+robert-manchester@users.noreply.github.com> --- pkgs/development/tools/nwjs/default.nix | 41 ++++++++----------------- 1 file changed, 13 insertions(+), 28 deletions(-) diff --git a/pkgs/development/tools/nwjs/default.nix b/pkgs/development/tools/nwjs/default.nix index 56cce99d7222..a4d058fc338c 100644 --- a/pkgs/development/tools/nwjs/default.nix +++ b/pkgs/development/tools/nwjs/default.nix @@ -21,7 +21,6 @@ , libuuid , libxcb , libxkbcommon -, makeWrapper , mesa , nspr , nss @@ -84,10 +83,11 @@ let extraOutputsToInstall = [ "lib" "out" ]; }; -in -stdenv.mkDerivation rec { - pname = "nwjs"; version = "0.82.0"; +in +stdenv.mkDerivation { + pname = "nwjs"; + inherit version; src = let flavor = if sdk then "sdk-" else ""; @@ -101,48 +101,33 @@ stdenv.mkDerivation rec { }."${flavor + bits}"; }; - nativeBuildInputs = [ makeWrapper autoPatchelfHook ]; - runtimeDependencies = [ sqlite libuuid udev ]; + nativeBuildInputs = [ autoPatchelfHook ]; + buildInputs = [ nwEnv ]; + appendRunpaths = map (pkg: (lib.getLib pkg) + "/lib") [ nwEnv stdenv.cc.libc stdenv.cc.cc ]; + + installPhase = '' + runHook preInstall - installPhase = - let ccPath = lib.makeLibraryPath [ stdenv.cc.cc ]; - in - '' mkdir -p $out/share/nwjs cp -R * $out/share/nwjs find $out/share/nwjs - patchelf --set-interpreter "$(cat $NIX_CC/nix-support/dynamic-linker)" $out/share/nwjs/nw - ln -s ${lib.getLib systemd}/lib/libudev.so $out/share/nwjs/libudev.so.0 - libpath="$out/share/nwjs/lib/" - for f in "$libpath"/*.so; do - patchelf --set-rpath "${nwEnv}/lib:${ccPath}:$libpath" "$f" - done - patchelf --set-rpath "${nwEnv}/lib:${nwEnv}/lib64:${ccPath}:$libpath" $out/share/nwjs/nw - # check, whether all RPATHs are correct (all dependencies found) - checkfile=$(mktemp) - for f in "$libpath"/*.so "$out/share/nwjs/nw"; do - (echo "$f:"; - ldd "$f" ) > "$checkfile" - done - if <"$checkfile" grep -e "not found"; then - cat "$checkfile" - exit 1 - fi - mkdir -p $out/bin ln -s $out/share/nwjs/nw $out/bin mkdir $out/lib ln -s $out/share/nwjs/lib/libnw.so $out/lib/libnw.so + + runHook postInstall ''; meta = with lib; { description = "An app runtime based on Chromium and node.js"; homepage = "https://nwjs.io/"; platforms = [ "i686-linux" "x86_64-linux" ]; + sourceProvenance = with sourceTypes; [ binaryNativeCode ]; maintainers = [ maintainers.offline ]; license = licenses.bsd3; }; From ab8d3140fb4f90d8ff9bae8c7507da8551bec25a Mon Sep 17 00:00:00 2001 From: Mikael Fangel <34864484+MikaelFangel@users.noreply.github.com> Date: Mon, 6 Nov 2023 14:44:35 +0100 Subject: [PATCH 4/6] nwjs: change maintainer to mikaelfangel --- pkgs/development/tools/nwjs/default.nix | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkgs/development/tools/nwjs/default.nix b/pkgs/development/tools/nwjs/default.nix index a4d058fc338c..000910c7c6a7 100644 --- a/pkgs/development/tools/nwjs/default.nix +++ b/pkgs/development/tools/nwjs/default.nix @@ -128,7 +128,7 @@ stdenv.mkDerivation { homepage = "https://nwjs.io/"; platforms = [ "i686-linux" "x86_64-linux" ]; sourceProvenance = with sourceTypes; [ binaryNativeCode ]; - maintainers = [ maintainers.offline ]; + maintainers = [ maintainers.mikaelfangel ]; license = licenses.bsd3; }; } From 80340d2b5f9a2d42989bf51f94de83672be63c5e Mon Sep 17 00:00:00 2001 From: Mikael Fangel <34864484+MikaelFangel@users.noreply.github.com> Date: Wed, 6 Dec 2023 09:37:54 +0100 Subject: [PATCH 5/6] nwjs: add mainprogram --- pkgs/development/tools/nwjs/default.nix | 1 + 1 file changed, 1 insertion(+) diff --git a/pkgs/development/tools/nwjs/default.nix b/pkgs/development/tools/nwjs/default.nix index 000910c7c6a7..cb230651e0b3 100644 --- a/pkgs/development/tools/nwjs/default.nix +++ b/pkgs/development/tools/nwjs/default.nix @@ -129,6 +129,7 @@ stdenv.mkDerivation { platforms = [ "i686-linux" "x86_64-linux" ]; sourceProvenance = with sourceTypes; [ binaryNativeCode ]; maintainers = [ maintainers.mikaelfangel ]; + mainProgram = "nw"; license = licenses.bsd3; }; } From b4c8a38c0fc6196ba9a0d8c27ec19f805cbafd7d Mon Sep 17 00:00:00 2001 From: Mikael Fangel <34864484+MikaelFangel@users.noreply.github.com> Date: Sat, 9 Dec 2023 00:48:23 +0100 Subject: [PATCH 6/6] nwjs: add NIXOS_OZONE_WL --- pkgs/development/tools/nwjs/default.nix | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/pkgs/development/tools/nwjs/default.nix b/pkgs/development/tools/nwjs/default.nix index cb230651e0b3..f88dc1f3f905 100644 --- a/pkgs/development/tools/nwjs/default.nix +++ b/pkgs/development/tools/nwjs/default.nix @@ -21,6 +21,7 @@ , libuuid , libxcb , libxkbcommon +, makeWrapper , mesa , nspr , nss @@ -30,6 +31,7 @@ , stdenv , systemd , udev +, wrapGAppsHook , xorg }: @@ -101,10 +103,20 @@ stdenv.mkDerivation { }."${flavor + bits}"; }; - nativeBuildInputs = [ autoPatchelfHook ]; + nativeBuildInputs = [ + autoPatchelfHook + (wrapGAppsHook.override { inherit makeWrapper; }) + ]; + buildInputs = [ nwEnv ]; appendRunpaths = map (pkg: (lib.getLib pkg) + "/lib") [ nwEnv stdenv.cc.libc stdenv.cc.cc ]; + preFixup = '' + gappsWrapperArgs+=( + --add-flags "\''${NIXOS_OZONE_WL:+\''${WAYLAND_DISPLAY:+--ozone-platform-hint=auto --enable-features=WaylandWindowDecorations}}" + ) + ''; + installPhase = '' runHook preInstall