From ca3e16048d12997820f32af8aa035add64c60511 Mon Sep 17 00:00:00 2001 From: Orivej Desh Date: Mon, 16 Sep 2024 13:56:14 +0000 Subject: [PATCH] musescore: use wrapGAppsHook3 on Linux only Since musescore/MuseScore@685ac998 GTK3 is needed on Linux for file dialogs. wrapGAppsNoGuiHook is not sufficient - without wrapGAppsHook3 mscore crashes in File -> Open when XDG_DATA_DIRS is unset. --- pkgs/applications/audio/musescore/default.nix | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/pkgs/applications/audio/musescore/default.nix b/pkgs/applications/audio/musescore/default.nix index 552561141720..a28b0b4e0d65 100644 --- a/pkgs/applications/audio/musescore/default.nix +++ b/pkgs/applications/audio/musescore/default.nix @@ -3,7 +3,7 @@ , fetchFromGitHub , fetchpatch , cmake -, wrapGAppsNoGuiHook +, wrapGAppsHook3 , wrapQtAppsHook , pkg-config , ninja @@ -103,14 +103,15 @@ in stdenv'.mkDerivation (finalAttrs: { dontWrapGApps = true; nativeBuildInputs = [ - # Just to make it not crash when looking up Gschemas when opening external - # files - wrapGAppsNoGuiHook wrapQtAppsHook cmake qttools pkg-config ninja + ] ++ lib.optionals stdenv.isLinux [ + # Since https://github.com/musescore/MuseScore/pull/13847/commits/685ac998 + # GTK3 is needed for file dialogs. Fixes crash with No GSettings schemas error. + wrapGAppsHook3 ]; buildInputs = [