From fc8061dae4731f7cd8043df9dc1c3bdbd8b10776 Mon Sep 17 00:00:00 2001 From: Sergei Trofimovich Date: Sun, 5 Jun 2022 20:23:12 +0100 Subject: [PATCH] percona-xtrabackup_2_4: add -fcommon workaround Workaround build failure on -fno-common toolchains like upstream gcc-10. Otherwise build fails as: ld: xbstream.c.o:(.bss+0x0): multiple definition of `datasink_buffer'; ds_buffer.c.o:(.data.rel.local+0x0): first defined here --- pkgs/tools/backup/percona-xtrabackup/generic.nix | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/pkgs/tools/backup/percona-xtrabackup/generic.nix b/pkgs/tools/backup/percona-xtrabackup/generic.nix index 7976b666bcdf..85e9ac6f364b 100644 --- a/pkgs/tools/backup/percona-xtrabackup/generic.nix +++ b/pkgs/tools/backup/percona-xtrabackup/generic.nix @@ -25,6 +25,11 @@ stdenv.mkDerivation rec { patches = extraPatches; + # Workaround build failure on -fno-common toolchains: + # ld: xbstream.c.o:(.bss+0x0): multiple definition of + # `datasink_buffer'; ds_buffer.c.o:(.data.rel.local+0x0): first defined here + NIX_CFLAGS_COMPILE = "-fcommon"; + cmakeFlags = [ "-DMYSQL_UNIX_ADDR=/run/mysqld/mysqld.sock" "-DBUILD_CONFIG=xtrabackup_release"