From 474f62e91479d82bc04eec72e68652eb80a3d64f Mon Sep 17 00:00:00 2001 From: Pol Dellaiera Date: Fri, 31 Oct 2025 13:09:52 +0100 Subject: [PATCH 1/2] build-support/go: clarify `vendorHash` So programs doesn't need dependencies (e.g., issue2md), that doesn't mean the dependencies are in the source tree. --- pkgs/build-support/go/module.nix | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkgs/build-support/go/module.nix b/pkgs/build-support/go/module.nix index c1c644e4294e..eaeb6e075ae4 100644 --- a/pkgs/build-support/go/module.nix +++ b/pkgs/build-support/go/module.nix @@ -24,8 +24,8 @@ lib.extendMkDerivation { modRoot ? "./", # The SRI hash of the vendored dependencies. - # If `vendorHash` is `null`, no dependencies are fetched and - # the build relies on the vendor folder within the source. + # If `null`, it means the project either has no external dependencies + # or the vendored dependencies are already present in the source tree. vendorHash ? throw ( if args ? vendorSha256 then "buildGoModule: Expect vendorHash instead of vendorSha256" From da95be33945199e317f18a47fda81879aa397aa0 Mon Sep 17 00:00:00 2001 From: Pol Dellaiera Date: Fri, 31 Oct 2025 13:14:16 +0100 Subject: [PATCH 2/2] issue2md: add `ldflags` Context: - https://github.com/NixOS/nixpkgs/pull/456918#discussion_r2479429015 - https://github.com/NixOS/nixpkgs/issues/346380 --- pkgs/by-name/is/issue2md/package.nix | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/pkgs/by-name/is/issue2md/package.nix b/pkgs/by-name/is/issue2md/package.nix index 8ccd32577397..947f354f96e4 100644 --- a/pkgs/by-name/is/issue2md/package.nix +++ b/pkgs/by-name/is/issue2md/package.nix @@ -17,6 +17,10 @@ buildGoModule (finalAttrs: { vendorHash = null; + ldflags = [ + "-s" + ]; + meta = { description = "CLI tool to convert GitHub issue into Markdown file"; homepage = "https://github.com/bigwhite/issue2md";