From 4273fc60d7f5bf1436d8885ff2e88a2b8d8221d5 Mon Sep 17 00:00:00 2001 From: Felix Singer Date: Thu, 19 Mar 2026 17:41:28 +0100 Subject: [PATCH] nixos/jenkins: Drop default packages from `package` option Not every Jenkins installation needs any package included in PATH. Drop the packages from `services.jenkins.packages` and leave the decision up to the user instead. Add a release note to 26.05 in order to notify users. Signed-off-by: Felix Singer --- doc/release-notes/rl-2605.section.md | 2 ++ .../continuous-integration/jenkins/default.nix | 18 ++++++++++-------- 2 files changed, 12 insertions(+), 8 deletions(-) diff --git a/doc/release-notes/rl-2605.section.md b/doc/release-notes/rl-2605.section.md index e582b68084a2..3694c7392df0 100644 --- a/doc/release-notes/rl-2605.section.md +++ b/doc/release-notes/rl-2605.section.md @@ -221,6 +221,8 @@ - `services.taskchampion-sync-server` module have been added an option `services.taskchampion-sync-server.dynamicUser` to use systemd's DynamicUser feature. This is enabled by default when stateVersion is at least 26.05, and disabled otherwise. If you need this feature, you need to set `services.taskchampion-sync-server.dynamicUser` to `true` and migrate `/var/lib/taskchampion-sync-server` to `/var/lib/private/taskchampion-sync-server`. +- The default packages in `services.jenkins.packages` have been dropped, since not every Jenkins installation needs any package at all. It's more reasonable to leave it empty and let users configure what they need. + ## Other Notable Changes {#sec-nixpkgs-release-26.05-notable-changes} diff --git a/nixos/modules/services/continuous-integration/jenkins/default.nix b/nixos/modules/services/continuous-integration/jenkins/default.nix index 15421ef2f532..d4657fcab8aa 100644 --- a/nixos/modules/services/continuous-integration/jenkins/default.nix +++ b/nixos/modules/services/continuous-integration/jenkins/default.nix @@ -86,14 +86,16 @@ in javaPackage = lib.mkPackageOption pkgs "jdk25" { }; packages = lib.mkOption { - default = [ - pkgs.stdenv - pkgs.git - pkgs.jdk25 - config.programs.ssh.package - pkgs.nix - ]; - defaultText = lib.literalExpression "[ pkgs.stdenv pkgs.git pkgs.jdk17 config.programs.ssh.package pkgs.nix ]"; + default = [ ]; + example = lib.literalExpression '' + [ + pkgs.stdenv + pkgs.git + pkgs.jdk25 + config.programs.ssh.package + pkgs.nix + ] + ''; type = lib.types.listOf lib.types.package; description = '' Packages to add to PATH for the jenkins process.