From 4e8f6593c0fe837b50facdf770807d036de3efd1 Mon Sep 17 00:00:00 2001 From: Gaetan Lepage Date: Mon, 2 Dec 2024 08:51:37 +0100 Subject: [PATCH 1/3] python312Packages.tensordict: enable now succeeding tests --- pkgs/development/python-modules/tensordict/default.nix | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/pkgs/development/python-modules/tensordict/default.nix b/pkgs/development/python-modules/tensordict/default.nix index 1ad591e13be6..9e7dd4e4ab56 100644 --- a/pkgs/development/python-modules/tensordict/default.nix +++ b/pkgs/development/python-modules/tensordict/default.nix @@ -70,13 +70,8 @@ buildPythonPackage rec { # + where tensor(False) = () "test_mp" - # torch._dynamo.exc.BackendCompilerFailed - # Requires a more recent version of triton - # Re-enable when https://github.com/NixOS/nixpkgs/pull/328247 is merged + # torch._dynamo.exc.InternalTorchDynamoError: RuntimeError: to_module requires TORCHDYNAMO_INLINE_INBUILT_NN_MODULES to be set. "test_functional" - "test_linear" - "test_seq" - "test_seq_lmbda" ] ++ lib.optionals (stdenv.hostPlatform.system == "aarch64-linux") [ # RuntimeError: internal error From e53e9be8c516832c9553e24d610c49699e33d969 Mon Sep 17 00:00:00 2001 From: Gaetan Lepage Date: Mon, 2 Dec 2024 08:52:04 +0100 Subject: [PATCH 2/3] python312Packages.tensordict: disable flaky test_map_iter_interrupt_early on all platforms --- pkgs/development/python-modules/tensordict/default.nix | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pkgs/development/python-modules/tensordict/default.nix b/pkgs/development/python-modules/tensordict/default.nix index 9e7dd4e4ab56..338711d80f97 100644 --- a/pkgs/development/python-modules/tensordict/default.nix +++ b/pkgs/development/python-modules/tensordict/default.nix @@ -72,6 +72,9 @@ buildPythonPackage rec { # torch._dynamo.exc.InternalTorchDynamoError: RuntimeError: to_module requires TORCHDYNAMO_INLINE_INBUILT_NN_MODULES to be set. "test_functional" + + # hangs forever on some CPUs + "test_map_iter_interrupt_early" ] ++ lib.optionals (stdenv.hostPlatform.system == "aarch64-linux") [ # RuntimeError: internal error @@ -81,9 +84,6 @@ buildPythonPackage rec { # _queue.Empty errors in multiprocessing tests "test_isend" - - # hangs forever - "test_map_iter_interrupt_early" ]; disabledTestPaths = lib.optionals stdenv.hostPlatform.isDarwin [ From 804b2e10ec90e9b3c0abe9390b35bffc809ae441 Mon Sep 17 00:00:00 2001 From: Gaetan Lepage Date: Mon, 2 Dec 2024 14:05:16 +0100 Subject: [PATCH 3/3] python312Packages.torchrl: skip flaky tests --- pkgs/development/python-modules/torchrl/default.nix | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/pkgs/development/python-modules/torchrl/default.nix b/pkgs/development/python-modules/torchrl/default.nix index 990e4df76be4..a1555b29357e 100644 --- a/pkgs/development/python-modules/torchrl/default.nix +++ b/pkgs/development/python-modules/torchrl/default.nix @@ -167,6 +167,10 @@ buildPythonPackage rec { # assert torch.get_num_threads() == max(1, init_threads - 3) # AssertionError: assert 23 == 21 "test_auto_num_threads" + + # Flaky (hangs indefinitely on some CPUs) + "test_gae_multidim" + "test_gae_param_as_tensor" ]; meta = {