From 40d295d46d18ac735b85da3cd42af22af9273b2a Mon Sep 17 00:00:00 2001 From: Samuel Dionne-Riel Date: Mon, 26 Jan 2026 21:29:22 -0500 Subject: [PATCH] Revert "workflows/eval.misc: run tasks in parallel" This reverts commit 3d9cb9f3553b74d5fbbaa467dc96c6994daf95d0. In 3d9cb9f3553b74d5fbbaa467dc96c6994daf95d0 (#436171), the two check commands were combined in the same step, and backgrounded, `wait`ing on their completion. `help wait` states the following: > If ID is not given, waits for all currently active child processes, > and the return status is zero. The result was that this check's misc check results were accidentally thrown away. Oops. --- .github/workflows/eval.yml | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/.github/workflows/eval.yml b/.github/workflows/eval.yml index 77dd85f6ae63..7a059230138a 100644 --- a/.github/workflows/eval.yml +++ b/.github/workflows/eval.yml @@ -453,10 +453,9 @@ jobs: - name: Install Nix uses: cachix/install-nix-action@4e002c8ec80594ecd40e759629461e26c8abed15 # v31 - - name: Run misc eval tasks in parallel + - name: Ensure flake outputs on all systems still evaluate + run: nix flake check --all-systems --no-build './nixpkgs/untrusted?shallow=1' + + - name: Query nixpkgs with aliases enabled to check for basic syntax errors run: | - # Ensure flake outputs on all systems still evaluate - nix flake check --all-systems --no-build './nixpkgs/untrusted?shallow=1' & - # Query nixpkgs with aliases enabled to check for basic syntax errors - nix-env -I ./nixpkgs/untrusted -f ./nixpkgs/untrusted -qa '*' --option restrict-eval true --option allow-import-from-derivation false >/dev/null & - wait + time nix-env -I ./nixpkgs/untrusted -f ./nixpkgs/untrusted -qa '*' --option restrict-eval true --option allow-import-from-derivation false >/dev/null