From 3ddf18ca4ecf35bfb54c712f3aa373f66037495a Mon Sep 17 00:00:00 2001 From: Gaetan Lepage Date: Mon, 6 Apr 2026 23:37:58 +0000 Subject: [PATCH] python3Packages.great-tables: cleanup, skip failing test --- .../python-modules/great-tables/default.nix | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/pkgs/development/python-modules/great-tables/default.nix b/pkgs/development/python-modules/great-tables/default.nix index 5df70362603e..21741589b5f8 100644 --- a/pkgs/development/python-modules/great-tables/default.nix +++ b/pkgs/development/python-modules/great-tables/default.nix @@ -33,7 +33,7 @@ syrupy, }: -buildPythonPackage rec { +buildPythonPackage (finalAttrs: { pname = "great-tables"; version = "0.21.0"; pyproject = true; @@ -41,7 +41,7 @@ buildPythonPackage rec { src = fetchFromGitHub { owner = "posit-dev"; repo = "great-tables"; - tag = "v${version}"; + tag = "v${finalAttrs.version}"; hash = "sha256-d5LKKA6KCkkBGibalWkfOTRzf48YEjdtjCdbGpW2AjE="; }; @@ -83,6 +83,10 @@ buildPythonPackage rec { "test_save_custom_webdriver" "test_save_image_file" "test_save_non_png" + + # AssertionError: assert [- snapshot] == [+ received] + # https://github.com/posit-dev/great-tables/issues/826 + "test_html_string_generated_inline_css" ] ++ lib.optionals stdenv.hostPlatform.isDarwin [ # Fails due to added newline in HTML output @@ -95,8 +99,8 @@ buildPythonPackage rec { meta = { description = "Library for rendering and formatting dataframes"; homepage = "https://github.com/posit-dev/great-tables"; - changelog = "https://github.com/posit-dev/great-tables/releases/tag/${src.tag}"; + changelog = "https://github.com/posit-dev/great-tables/releases/tag/${finalAttrs.src.tag}"; license = lib.licenses.mit; maintainers = with lib.maintainers; [ bcdarwin ]; }; -} +})