From 5b78ac752259a38640c9d94dff9a325fda2565b9 Mon Sep 17 00:00:00 2001 From: Noa Aarts Date: Tue, 29 Oct 2024 10:12:23 +0100 Subject: [PATCH 1/3] kitsas: 4.0.5 -> 5.7 --- pkgs/applications/office/kitsas/default.nix | 53 +++++++++++++-------- pkgs/top-level/all-packages.nix | 2 +- 2 files changed, 35 insertions(+), 20 deletions(-) diff --git a/pkgs/applications/office/kitsas/default.nix b/pkgs/applications/office/kitsas/default.nix index 9821cdd2f2f8..8c2def9fda0e 100644 --- a/pkgs/applications/office/kitsas/default.nix +++ b/pkgs/applications/office/kitsas/default.nix @@ -1,24 +1,37 @@ -{ lib, stdenv, fetchFromGitHub, qmake, qtsvg, poppler, libzip, pkg-config, wrapQtAppsHook }: +{ + lib, + stdenv, + fetchFromGitHub, + qt6, + poppler, + libzip, + pkg-config, +}: stdenv.mkDerivation rec { pname = "kitsas"; - version = "4.0.5"; + version = "5.7"; src = fetchFromGitHub { owner = "artoh"; repo = "kitupiikki"; rev = "v${version}"; - hash = "sha256-ODl1yrtrCVhuBWbA1AvHl22d+JSdySG/Gi2hlpVW3jg="; + hash = "sha256-1TZFw1Q9+FsGHwitErDhwyA941rtb+h9OgJLFLyhV7k="; }; - postPatch = '' - substituteInPlace kitsas/kitsas.pro \ - --replace "LIBS += -L/usr/local/opt/poppler-qt5/lib -lpoppler-qt6" "LIBS += -lpoppler-qt5" - ''; + nativeBuildInputs = [ + pkg-config + qt6.qmake + qt6.wrapQtAppsHook + ]; - nativeBuildInputs = [ pkg-config qmake wrapQtAppsHook ]; - - buildInputs = [ qtsvg poppler libzip ]; + buildInputs = [ + libzip + poppler + qt6.qt5compat + qt6.qtsvg + qt6.qtwebengine + ]; # We use a separate build-dir as otherwise ld seems to get confused between # directory and executable name on buildPhase. @@ -28,15 +41,17 @@ stdenv.mkDerivation rec { qmakeFlags = [ "../kitsas/kitsas.pro" ]; - installPhase = lib.optionalString stdenv.hostPlatform.isDarwin '' - mkdir -p $out/Applications - mv kitsas.app $out/Applications - '' + lib.optionalString (!stdenv.hostPlatform.isDarwin) '' - install -Dm755 kitsas -t $out/bin - install -Dm644 ../kitsas.svg -t $out/share/icons/hicolor/scalable/apps - install -Dm644 ../kitsas.png -t $out/share/icons/hicolor/256x256/apps - install -Dm644 ../kitsas.desktop -t $out/share/applications - ''; + installPhase = + lib.optionalString stdenv.hostPlatform.isDarwin '' + mkdir -p $out/Applications + mv kitsas.app $out/Applications + '' + + lib.optionalString (!stdenv.hostPlatform.isDarwin) '' + install -Dm755 kitsas -t $out/bin + install -Dm644 ../kitsas.svg -t $out/share/icons/hicolor/scalable/apps + install -Dm644 ../kitsas.png -t $out/share/icons/hicolor/256x256/apps + install -Dm644 ../kitsas.desktop -t $out/share/applications + ''; meta = with lib; { homepage = "https://github.com/artoh/kitupiikki"; diff --git a/pkgs/top-level/all-packages.nix b/pkgs/top-level/all-packages.nix index 93f3939af957..bcd0ba6a1d34 100644 --- a/pkgs/top-level/all-packages.nix +++ b/pkgs/top-level/all-packages.nix @@ -30233,7 +30233,7 @@ with pkgs; kile = callPackage ../applications/editors/kile { }; - kitsas = libsForQt5.callPackage ../applications/office/kitsas { }; + kitsas = callPackage ../applications/office/kitsas { }; kiwix = libsForQt5.callPackage ../applications/misc/kiwix { }; From 74b36317c02d4a2fded94cc23017de19fb4bb2ad Mon Sep 17 00:00:00 2001 From: Noa Aarts Date: Tue, 29 Oct 2024 10:14:48 +0100 Subject: [PATCH 2/3] kitsas: move to by-name --- .../office/kitsas/default.nix => by-name/ki/kitsas/package.nix} | 0 pkgs/top-level/all-packages.nix | 2 -- 2 files changed, 2 deletions(-) rename pkgs/{applications/office/kitsas/default.nix => by-name/ki/kitsas/package.nix} (100%) diff --git a/pkgs/applications/office/kitsas/default.nix b/pkgs/by-name/ki/kitsas/package.nix similarity index 100% rename from pkgs/applications/office/kitsas/default.nix rename to pkgs/by-name/ki/kitsas/package.nix diff --git a/pkgs/top-level/all-packages.nix b/pkgs/top-level/all-packages.nix index bcd0ba6a1d34..52aca76805b0 100644 --- a/pkgs/top-level/all-packages.nix +++ b/pkgs/top-level/all-packages.nix @@ -30233,8 +30233,6 @@ with pkgs; kile = callPackage ../applications/editors/kile { }; - kitsas = callPackage ../applications/office/kitsas { }; - kiwix = libsForQt5.callPackage ../applications/misc/kiwix { }; kiwix-tools = callPackage ../applications/misc/kiwix/tools.nix { }; From 8ad33345994535aa335d6c3ca15805bc70883f2a Mon Sep 17 00:00:00 2001 From: Noa Aarts Date: Tue, 29 Oct 2024 10:21:22 +0100 Subject: [PATCH 3/3] kitsas: add qtwayland build input for linux --- pkgs/by-name/ki/kitsas/package.nix | 18 +++++++++++------- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/pkgs/by-name/ki/kitsas/package.nix b/pkgs/by-name/ki/kitsas/package.nix index 8c2def9fda0e..854c53cc5327 100644 --- a/pkgs/by-name/ki/kitsas/package.nix +++ b/pkgs/by-name/ki/kitsas/package.nix @@ -25,13 +25,17 @@ stdenv.mkDerivation rec { qt6.wrapQtAppsHook ]; - buildInputs = [ - libzip - poppler - qt6.qt5compat - qt6.qtsvg - qt6.qtwebengine - ]; + buildInputs = + [ + libzip + poppler + qt6.qt5compat + qt6.qtsvg + qt6.qtwebengine + ] + ++ lib.optional stdenv.hostPlatform.isLinux [ + qt6.qtwayland + ]; # We use a separate build-dir as otherwise ld seems to get confused between # directory and executable name on buildPhase.