From f9696ce33be44dfd70ec11293d0cdab439409ddd Mon Sep 17 00:00:00 2001 From: Evgeny Kurnevsky Date: Wed, 20 Aug 2025 15:11:50 +0200 Subject: [PATCH] llama-cpp: allow to override ROCM GPU targets --- pkgs/by-name/ll/llama-cpp/package.nix | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkgs/by-name/ll/llama-cpp/package.nix b/pkgs/by-name/ll/llama-cpp/package.nix index 9a76c27bbadf..2b32c2d49b1a 100644 --- a/pkgs/by-name/ll/llama-cpp/package.nix +++ b/pkgs/by-name/ll/llama-cpp/package.nix @@ -12,6 +12,7 @@ rocmSupport ? config.rocmSupport, rocmPackages ? { }, + rocmGpuTargets ? builtins.concatStringsSep ";" rocmPackages.clr.gpuTargets, openclSupport ? false, clblast, @@ -146,8 +147,7 @@ effectiveStdenv.mkDerivation (finalAttrs: { ] ++ optionals rocmSupport [ (cmakeFeature "CMAKE_HIP_COMPILER" "${rocmPackages.clr.hipClangPath}/clang++") - # TODO: this should become `clr.gpuTargets` in the future. - (cmakeFeature "CMAKE_HIP_ARCHITECTURES" rocmPackages.rocblas.amdgpu_targets) + (cmakeFeature "CMAKE_HIP_ARCHITECTURES" rocmGpuTargets) ] ++ optionals metalSupport [ (cmakeFeature "CMAKE_C_FLAGS" "-D__ARM_FEATURE_DOTPROD=1")