From 3c2cbd04cb034c067fca1f9f454e15c15ae1e4dc Mon Sep 17 00:00:00 2001 From: Luna Nova Date: Fri, 12 Sep 2025 21:30:05 -0700 Subject: [PATCH] python3Packages.torchWithRocm: allow gfx1151 (Strix Halo) gfx1151 support in torch was fixed by the ROCm 6.4 bump --- pkgs/development/python-modules/torch/source/default.nix | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/pkgs/development/python-modules/torch/source/default.nix b/pkgs/development/python-modules/torch/source/default.nix index aa6de6c0a2aa..e8d2cf720165 100644 --- a/pkgs/development/python-modules/torch/source/default.nix +++ b/pkgs/development/python-modules/torch/source/default.nix @@ -187,11 +187,7 @@ let # TODO: Retest after ROCm 6.4 or torch 2.8 "gfx1010" "gfx1012" - - # Strix Halo seems to be broken as well, see - # https://github.com/NixOS/nixpkgs/pull/440359. - "gfx1151" - ] (rocmPackages.clr.localGpuTargets or rocmPackages.clr.gpuTargets) + ] rocmPackages.clr.localGpuTargets or rocmPackages.clr.gpuTargets else throw "No GPU targets specified" ); @@ -412,7 +408,7 @@ buildPythonPackage rec { export ROCM_PATH=${rocmtoolkit_joined} export ROCM_SOURCE_DIR=${rocmtoolkit_joined} export PYTORCH_ROCM_ARCH="${gpuTargetString}" - export CMAKE_CXX_FLAGS="-I${rocmtoolkit_joined}/include -I${rocmtoolkit_joined}/include/rocblas" + export CMAKE_CXX_FLAGS="-I${rocmtoolkit_joined}/include" python tools/amd_build/build_amd.py '';