From 3abe6557dd962ba5c04008da744ad6b148f0e340 Mon Sep 17 00:00:00 2001
From: PhiliPdB <phlpdbrn@gmail.com>
Date: Mon, 5 May 2025 09:53:18 +0200
Subject: [PATCH] pympress: 1.8.5 -> 1.8.6

Also includes:
- Build from source
- Modernize
---
 pkgs/by-name/py/pympress/package.nix | 45 ++++++++++++++++------------
 1 file changed, 26 insertions(+), 19 deletions(-)

diff --git a/pkgs/by-name/py/pympress/package.nix b/pkgs/by-name/py/pympress/package.nix
index 8c8801fe8cd9..3532bf57d737 100644
--- a/pkgs/by-name/py/pympress/package.nix
+++ b/pkgs/by-name/py/pympress/package.nix
@@ -2,7 +2,7 @@
   lib,
   stdenv,
   python3Packages,
-  fetchPypi,
+  fetchFromGitHub,
   wrapGAppsHook3,
   gtk3,
   gobject-introspection,
@@ -15,14 +15,31 @@
 
 python3Packages.buildPythonApplication rec {
   pname = "pympress";
-  version = "1.8.5";
+  version = "1.8.6";
 
-  src = fetchPypi {
-    inherit version;
-    pname = "pympress";
-    hash = "sha256-Kb05EV0F8lTamTq7pC1UoOkYf04s58NjMksVE2xTC/Y=";
+  src = fetchFromGitHub {
+    owner = "cimbali";
+    repo = "pympress";
+    tag = "v${version}";
+    hash = "sha256-rIlYd5SMWYeqdMHyW3d1ggKnUMCJCDP5uw25d7zG2DU=";
   };
 
+  build-system = with python3Packages; [
+    setuptools
+    babel
+  ];
+
+  dependencies =
+    with python3Packages;
+    [
+      watchdog
+      pycairo
+      pygobject3
+    ]
+    ++ lib.optional withVLC [
+      python-vlc
+    ];
+
   nativeBuildInputs = [
     wrapGAppsHook3
     gobject-introspection
@@ -44,23 +61,13 @@ python3Packages.buildPythonApplication rec {
       gst_all_1.gst-vaapi
     ];
 
-  propagatedBuildInputs =
-    with python3Packages;
-    [
-      pycairo
-      pygobject3
-      setuptools
-      watchdog
-    ]
-    ++ lib.optional withVLC python-vlc;
-
   doCheck = false; # there are no tests
 
-  meta = with lib; {
+  meta = {
     description = "Simple yet powerful PDF reader designed for dual-screen presentations";
     mainProgram = "pympress";
-    license = licenses.gpl2Plus;
+    license = lib.licenses.gpl2Plus;
     homepage = "https://cimbali.github.io/pympress/";
-    maintainers = [ maintainers.tbenst ];
+    maintainers = with lib.maintainers; [ tbenst ];
   };
 }