From 3a731d0d3502d9d718d0c90b2f0aac9b7e4d3369 Mon Sep 17 00:00:00 2001 From: phiadaarr <33826198+phiadaarr@users.noreply.github.com> Date: Wed, 13 Nov 2024 23:30:08 +0100 Subject: [PATCH] python312Packages.nanobind: reenable checks on x86_64-darwin (#355191) This patch reenables all checks except the ones depending on tensorflow and jax for x64_64-darwin. They have been disabled because tensorflow-bin is not available on x64_64-darwin (#327844). However, this was overkill. The nanobind tests themselves check if tensorflow is available or not and skip the respective test cases. --- .../python-modules/nanobind/default.nix | 23 ++++++++++--------- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/pkgs/development/python-modules/nanobind/default.nix b/pkgs/development/python-modules/nanobind/default.nix index f08378fdec68..63070760c9b4 100644 --- a/pkgs/development/python-modules/nanobind/default.nix +++ b/pkgs/development/python-modules/nanobind/default.nix @@ -53,17 +53,18 @@ buildPythonPackage rec { make -j $NIX_BUILD_CORES ''; - # skip testing on platforms disabled for tensorflow-bin - doCheck = !(builtins.elem stdenv.hostPlatform.system tensorflow-bin.meta.badPlatforms); - nativeCheckInputs = [ - pytestCheckHook - numpy - scipy - torch - tensorflow-bin - jax - jaxlib - ]; + nativeCheckInputs = + [ + pytestCheckHook + numpy + scipy + torch + ] + ++ lib.optionals (!(builtins.elem stdenv.hostPlatform.system tensorflow-bin.meta.badPlatforms)) [ + tensorflow-bin + jax + jaxlib + ]; meta = { homepage = "https://github.com/wjakob/nanobind";