From 391a164758dc0e5739ec6ef54a7294e6bd35592d Mon Sep 17 00:00:00 2001 From: zion Date: Sun, 15 Mar 2026 22:19:33 +0800 Subject: [PATCH] nixos/dms-greeter: skip invalid customThemeFile in preStart Avoid attempting to copy a null/empty/missing customThemeFile path by validating the jq result and file existence before cp. --- nixos/modules/services/display-managers/dms-greeter.nix | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/nixos/modules/services/display-managers/dms-greeter.nix b/nixos/modules/services/display-managers/dms-greeter.nix index abdd6e2ddf3b..f5b464303638 100644 --- a/nixos/modules/services/display-managers/dms-greeter.nix +++ b/nixos/modules/services/display-managers/dms-greeter.nix @@ -290,7 +290,9 @@ in fi if [ -f settings.json ]; then - if cp "$(${jq} -r '.customThemeFile' settings.json)" custom-theme.json; then + theme_file="$(${jq} -r '.customThemeFile // empty' settings.json)" + if [ -f "$theme_file" ] && [ -r "$theme_file" ]; then + cp "$theme_file" custom-theme.json mv settings.json settings.orig.json ${jq} '.customThemeFile = "${cacheDir}/custom-theme.json"' settings.orig.json > settings.json fi