From 37c369c6f847e8a87b11e5a3560ed5d0f73aeeca Mon Sep 17 00:00:00 2001 From: Kenichi Kamiya Date: Thu, 5 Feb 2026 19:31:37 +0900 Subject: [PATCH] whosthere: fix version display Switched to `versionCheckHook` to prevent similar issues, as we easily miss running `passthru.tests`. --- pkgs/by-name/wh/whosthere/package.nix | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/pkgs/by-name/wh/whosthere/package.nix b/pkgs/by-name/wh/whosthere/package.nix index bb64af813231..f45311d62f01 100644 --- a/pkgs/by-name/wh/whosthere/package.nix +++ b/pkgs/by-name/wh/whosthere/package.nix @@ -3,8 +3,7 @@ fetchFromGitHub, lib, nix-update-script, - testers, - whosthere, + versionCheckHook, }: buildGoModule (finalAttrs: { @@ -20,6 +19,12 @@ buildGoModule (finalAttrs: { vendorHash = "sha256-YVPsWpIXC5SLm+T2jEGqF4MBcKOAAk0Vpc7zCIFkNw8="; + ldflags = [ + "-s" + "-X" + "main.versionStr=${finalAttrs.version}" + ]; + checkFlags = let # Skip tests that require filesystem access @@ -30,8 +35,12 @@ buildGoModule (finalAttrs: { in [ "-skip=^${builtins.concatStringsSep "$|^" skippedTests}$" ]; + nativeInstallCheckInputs = [ + versionCheckHook + ]; + doInstallCheck = true; + passthru.updateScript = nix-update-script { }; - passthru.tests.version = testers.testVersion { package = whosthere; }; meta = { description = "Local Area Network discovery tool";