gador/nixpkgs
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

noBrokenSymlinks: check for unreadable symlinks

Browse Source 
Resolves #380681.
This commit is contained in:
Rhys-T
2025-02-09 12:44:31 -05:00
parent 6f4f89fb8a
commit 3703e38135
1 changed files with 10 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
pkgs/build-support/setup-hooks/no-broken-symlinks.sh
View File

@@ -13,7 +13,8 @@ postFixupHooks+=(noBrokenSymlinksInAllOutputs)
# A symlink is "dangling" if it points to a non-existent target. # A symlink is "dangling" if it points to a non-existent target.
# A symlink is "reflexive" if it points to itself. # A symlink is "reflexive" if it points to itself.
# A symlink is considered "broken" if it is either dangling or reflexive. # A symlink is "unreadable" if the readlink command fails, e.g. because of permission errors.
# A symlink is considered "broken" if it is either dangling, reflexive or unreadable.
noBrokenSymlinks() { noBrokenSymlinks() {
local -r output="${1:?}" local -r output="${1:?}"
local path local path
@@ -21,6 +22,7 @@ noBrokenSymlinks() {
local symlinkTarget local symlinkTarget
local -i numDanglingSymlinks=0 local -i numDanglingSymlinks=0
local -i numReflexiveSymlinks=0 local -i numReflexiveSymlinks=0
local -i numUnreadableSymlinks=0
# NOTE(@connorbaker): This hook doesn't check for cycles in symlinks. # NOTE(@connorbaker): This hook doesn't check for cycles in symlinks.
@@ -33,7 +35,11 @@ noBrokenSymlinks() {
# NOTE: path is absolute because we're running `find` against an absolute path (`output`). # NOTE: path is absolute because we're running `find` against an absolute path (`output`).
while IFS= read -r -d $'\0' path; do while IFS= read -r -d $'\0' path; do
pathParent="$(dirname "$path")" pathParent="$(dirname "$path")"
symlinkTarget="$(readlink "$path")" if ! symlinkTarget="$(readlink "$path")"; then
nixErrorLog "the symlink $path is unreadable"
numUnreadableSymlinks+=1
continue
fi
# Canonicalize symlinkTarget to an absolute path. # Canonicalize symlinkTarget to an absolute path.
if [[ $symlinkTarget == /* ]]; then if [[ $symlinkTarget == /* ]]; then
@@ -61,8 +67,8 @@ noBrokenSymlinks() {
fi fi
done < <(find "$output" -type l -print0) done < <(find "$output" -type l -print0)
if ((numDanglingSymlinks > 0 || numReflexiveSymlinks > 0)); then if ((numDanglingSymlinks > 0 || numReflexiveSymlinks > 0 || numUnreadableSymlinks > 0)); then
nixErrorLog "found $numDanglingSymlinks dangling symlinks and $numReflexiveSymlinks reflexive symlinks" nixErrorLog "found $numDanglingSymlinks dangling symlinks, $numReflexiveSymlinks reflexive symlinks and $numUnreadableSymlinks unreadable symlinks"
exit 1 exit 1
fi fi
return 0 return 0