From fbd8e3e405efcd88dbc43aeda9128dd88d20748b Mon Sep 17 00:00:00 2001 From: Daniel Baker Date: Tue, 17 Dec 2024 10:58:10 -0800 Subject: [PATCH 1/2] genemichaels: 0.5.7 -> 0.5.13 Bumps to the latest working version of genemichaels. Includes an update so that files are not written if they are already formatted correctly. Removes a failing test that was present from version 0.5.8 to 0.5.12. --- pkgs/by-name/ge/genemichaels/package.nix | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pkgs/by-name/ge/genemichaels/package.nix b/pkgs/by-name/ge/genemichaels/package.nix index 557e17934a28..f332cab62f6c 100644 --- a/pkgs/by-name/ge/genemichaels/package.nix +++ b/pkgs/by-name/ge/genemichaels/package.nix @@ -6,16 +6,16 @@ rustPlatform.buildRustPackage rec { pname = "genemichaels"; - version = "0.5.7"; + version = "0.5.13"; src = fetchFromGitHub { owner = "andrewbaxter"; repo = "genemichaels"; rev = "genemichaels-v${version}"; - hash = "sha256-qPyIC9AbRQI+inBft7Dd5R5v+tXtJcZdiV4lBIBwpyM="; + hash = "sha256-pzGTKswETm7RR0up1eSWC+X633rsVmEAJ3DYM8z6paQ="; }; - cargoHash = "sha256-yPxgYf8N3Dqns/uKhdM++jpzG7zTPhCVVq+7WA9G/SM="; + cargoHash = "sha256-FjggpBTzxj9AOJjUq5PmbuE/ImmTMpxN0se9uxRy4KQ="; cargoBuildFlags = [ "--package ${pname}" ]; From cc910e2bc7421be139e29eaaaacc10f912dc1c06 Mon Sep 17 00:00:00 2001 From: Daniel Baker Date: Tue, 17 Dec 2024 11:03:55 -0800 Subject: [PATCH 2/2] genemichaels: add comment about cargoTestFlags Adds a rationale about why cargoTestFlags is not used. --- pkgs/by-name/ge/genemichaels/package.nix | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/pkgs/by-name/ge/genemichaels/package.nix b/pkgs/by-name/ge/genemichaels/package.nix index f332cab62f6c..0decad7a3c83 100644 --- a/pkgs/by-name/ge/genemichaels/package.nix +++ b/pkgs/by-name/ge/genemichaels/package.nix @@ -18,6 +18,11 @@ rustPlatform.buildRustPackage rec { cargoHash = "sha256-FjggpBTzxj9AOJjUq5PmbuE/ImmTMpxN0se9uxRy4KQ="; cargoBuildFlags = [ "--package ${pname}" ]; + # cargoTestFlags is not used because genemichaels is tightly coupled to the + # other crates in the workspace and by not setting it, we run all the tests. + # If a dependency crate is failing its tests, we want to know about it. For + # example, between versions 0.5.8 and 0.5.12, there was a failing test in one + # of the other workspace members that genemichaels depends on. meta = { description = "Even formats macros";