From 2826d21d4a530deac71e099fc14c927fe5a63fc4 Mon Sep 17 00:00:00 2001 From: Gaetan Lepage Date: Wed, 29 Apr 2026 14:40:21 +0000 Subject: [PATCH 1/2] rerun: 0.31.3 -> 0.31.4 Diff: https://github.com/rerun-io/rerun/compare/0.31.3...0.31.4 Changelog: https://github.com/rerun-io/rerun/blob/0.31.4/CHANGELOG.md --- pkgs/by-name/re/rerun/package.nix | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pkgs/by-name/re/rerun/package.nix b/pkgs/by-name/re/rerun/package.nix index 15ac6bfe4504..c5e697076289 100644 --- a/pkgs/by-name/re/rerun/package.nix +++ b/pkgs/by-name/re/rerun/package.nix @@ -35,7 +35,7 @@ }: rustPlatform.buildRustPackage (finalAttrs: { pname = "rerun"; - version = "0.31.3"; + version = "0.31.4"; outputs = [ "out" @@ -46,7 +46,7 @@ rustPlatform.buildRustPackage (finalAttrs: { owner = "rerun-io"; repo = "rerun"; tag = finalAttrs.version; - hash = "sha256-ApGrW3E7r5lulBNB89HCP/WKBtwV7OABueQxqElF6rs="; + hash = "sha256-gbN9aplPw+U4liGDU7Z0x+ySfxr+RlyriEkDsIA8gHA="; }; # The path in `build.rs` is wrong for some reason, so we patch it to make the passthru tests work @@ -55,7 +55,7 @@ rustPlatform.buildRustPackage (finalAttrs: { --replace-fail '"rerun_sdk/rerun_cli/rerun"' '"rerun_sdk/rerun"' ''; - cargoHash = "sha256-JpYKJ8LRAMTy8TPQ2tk5o9b6Z2sgTkSVwULoCO3fYSk="; + cargoHash = "sha256-N5JeZMbGy9FSiluE1MAtvg97dUq3ZoUZdABwORUlWlA="; cargoBuildFlags = [ "--package" From 7532a870f2ede7eb817c94e6f2221d600ff1ac9d Mon Sep 17 00:00:00 2001 From: Gaetan Lepage Date: Wed, 29 Apr 2026 15:04:17 +0000 Subject: [PATCH 2/2] rerun: enable __structuredAttrs and strictDeps --- pkgs/by-name/re/rerun/package.nix | 21 +++++++++++-------- .../python-modules/rerun-sdk/default.nix | 1 + 2 files changed, 13 insertions(+), 9 deletions(-) diff --git a/pkgs/by-name/re/rerun/package.nix b/pkgs/by-name/re/rerun/package.nix index c5e697076289..3dd835194f7a 100644 --- a/pkgs/by-name/re/rerun/package.nix +++ b/pkgs/by-name/re/rerun/package.nix @@ -37,6 +37,9 @@ rustPlatform.buildRustPackage (finalAttrs: { pname = "rerun"; version = "0.31.4"; + __structuredAttrs = true; + strictDeps = true; + outputs = [ "out" "dev" @@ -83,19 +86,19 @@ rustPlatform.buildRustPackage (finalAttrs: { # Note that cargoBuildFeatures reference what buildFeatures is set to in stdenv.mkDerivation, # so that user can easily create an overlay to set cargoBuildFeatures to what he needs preBuild = '' - if [[ " $cargoBuildFeatures " == *" web_viewer "* ]]; then - # transform the environment variable that is a space separated list into a comma separated list - buildWebViewerFeatures=$(echo $buildWebViewerFeatures | tr ' ' ',') + if [[ " ''${cargoBuildFeatures[*]} " == *" web_viewer "* ]]; then + # join the bash array into a comma-separated list for cargo's --features flag + buildWebViewerFeaturesJoined=$(IFS=,; echo "''${buildWebViewerFeatures[*]}") # Create the features option only if there are features to pass - buildWebViewerFeaturesCargoOption="" - if [[ ! -z "$buildWebViewerFeatures" ]]; then - buildWebViewerFeaturesCargoOption="--features $buildWebViewerFeatures" - echo "Features passed to the web viewer build: $buildWebViewerFeatures" + buildWebViewerFeaturesCargoOption=() + if [[ -n "$buildWebViewerFeaturesJoined" ]]; then + buildWebViewerFeaturesCargoOption=("--features" "$buildWebViewerFeaturesJoined") + echo "Features passed to the web viewer build: $buildWebViewerFeaturesJoined" else echo "No features will be passed to the web viewer build" fi echo "Building the wasm web viewer for rerun's web_viewer feature" - cargo run -p re_dev_tools -- build-web-viewer --no-default-features $buildWebViewerFeaturesCargoOption --release -g + cargo run -p re_dev_tools -- build-web-viewer --no-default-features "''${buildWebViewerFeaturesCargoOption[@]}" --release -g else echo "web_viewer feature not enabled, skipping web viewer build." fi @@ -159,7 +162,7 @@ rustPlatform.buildRustPackage (finalAttrs: { while IFS= read -r -d $'\0' path ; do elfHasDynamicSection "$path" || continue - for dep in $addDlopenRunpaths ; do + for dep in "''${addDlopenRunpaths[@]}" ; do patchelf "$path" --add-rpath "$dep" done done < <( diff --git a/pkgs/development/python-modules/rerun-sdk/default.nix b/pkgs/development/python-modules/rerun-sdk/default.nix index 0bae3f20b92c..60fe41dff852 100644 --- a/pkgs/development/python-modules/rerun-sdk/default.nix +++ b/pkgs/development/python-modules/rerun-sdk/default.nix @@ -31,6 +31,7 @@ buildPythonPackage { pname = "rerun-sdk"; pyproject = true; + __structuredAttrs = true; inherit (rerun) src