From 48a49f76d77375018dbdb719b59fc6d8ed52104d Mon Sep 17 00:00:00 2001 From: adisbladis Date: Mon, 4 Dec 2023 15:28:01 +1300 Subject: [PATCH 1/2] python3.pkgs.pypaBuildHook: Fix passthru.tests --- pkgs/development/interpreters/python/hooks/default.nix | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkgs/development/interpreters/python/hooks/default.nix b/pkgs/development/interpreters/python/hooks/default.nix index 0557c62eeff4..04748df7f49c 100644 --- a/pkgs/development/interpreters/python/hooks/default.nix +++ b/pkgs/development/interpreters/python/hooks/default.nix @@ -68,8 +68,8 @@ in { # Such conflicts don't happen within the standard nixpkgs python package # set, but in downstream projects that build packages depending on other # versions of this hook's dependencies. - passthru.tests = import ./pypa-build-hook-test.nix { - inherit pythonOnBuildForHost runCommand; + passthru.tests = callPackage ./pypa-build-hook-test.nix { + inherit pythonOnBuildForHost; }; } ./pypa-build-hook.sh) { inherit (pythonOnBuildForHost.pkgs) build; From e23b9013214a82ccb85bf42c10ff52253b6dd126 Mon Sep 17 00:00:00 2001 From: adisbladis Date: Mon, 4 Dec 2023 15:30:17 +1300 Subject: [PATCH 2/2] python3.hooks: Dont completely overwrite passthru when creating setup hook --- pkgs/development/interpreters/python/hooks/default.nix | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/pkgs/development/interpreters/python/hooks/default.nix b/pkgs/development/interpreters/python/hooks/default.nix index 04748df7f49c..bc7d011944e1 100644 --- a/pkgs/development/interpreters/python/hooks/default.nix +++ b/pkgs/development/interpreters/python/hooks/default.nix @@ -8,7 +8,9 @@ let pythonCheckInterpreter = python.interpreter; setuppy = ../run_setup.py; in { - makePythonHook = args: pkgs.makeSetupHook ({passthru.provides.setupHook = true; } // args); + makePythonHook = let + defaultArgs = { passthru.provides.setupHook = true; }; + in args: pkgs.makeSetupHook (lib.recursiveUpdate defaultArgs args); condaInstallHook = callPackage ({ makePythonHook, gnutar, lbzip2 }: makePythonHook {