From d3f49bf5d852d406a8b7f5c543ee0cb58fef96a3 Mon Sep 17 00:00:00 2001 From: Roman Volosatovs Date: Sun, 16 Sep 2018 18:20:18 +0200 Subject: [PATCH 1/4] goimports: Remove in favor of gotools --- pkgs/development/tools/goimports/default.nix | 16 ---------------- pkgs/top-level/aliases.nix | 1 + pkgs/top-level/all-packages.nix | 2 -- 3 files changed, 1 insertion(+), 18 deletions(-) delete mode 100644 pkgs/development/tools/goimports/default.nix diff --git a/pkgs/development/tools/goimports/default.nix b/pkgs/development/tools/goimports/default.nix deleted file mode 100644 index 14c319320d0c..000000000000 --- a/pkgs/development/tools/goimports/default.nix +++ /dev/null @@ -1,16 +0,0 @@ -{ stdenv, buildGoPackage, fetchgit }: - -buildGoPackage rec { - name = "goimports-${version}"; - version = "20160519-${stdenv.lib.strings.substring 0 7 rev}"; - rev = "9ae4729fba20b3533d829a9c6ba8195b068f2abc"; - - goPackagePath = "golang.org/x/tools"; - subPackages = [ "cmd/goimports" ]; - - src = fetchgit { - inherit rev; - url = "https://go.googlesource.com/tools"; - sha256 = "1j51aaskfqc953p5s9naqimr04hzfijm4yczdsiway1xnnvvpfr1"; - }; -} diff --git a/pkgs/top-level/aliases.nix b/pkgs/top-level/aliases.nix index b8298b76d778..26bc7ebc6f1a 100644 --- a/pkgs/top-level/aliases.nix +++ b/pkgs/top-level/aliases.nix @@ -106,6 +106,7 @@ mapAliases ({ gnome_themes_standard = gnome-themes-standard; # added 2018-02-25 gnustep-make = gnustep.make; # added 2016-7-6 go-pup = pup; # added 2017-12-19 + goimports = gotools; # added 2018-09-16 googleAuthenticator = google-authenticator; # added 2016-10-16 grantlee5 = libsForQt5.grantlee; # added 2015-12-19 gsettings_desktop_schemas = gsettings-desktop-schemas; # added 2018-02-25 diff --git a/pkgs/top-level/all-packages.nix b/pkgs/top-level/all-packages.nix index 493f0d8ae6e7..571c900e27dd 100644 --- a/pkgs/top-level/all-packages.nix +++ b/pkgs/top-level/all-packages.nix @@ -14488,8 +14488,6 @@ with pkgs; godef = callPackage ../development/tools/godef { }; - goimports = callPackage ../development/tools/goimports { }; - gopkgs = callPackage ../development/tools/gopkgs { }; govers = callPackage ../development/tools/govers { }; From 09a5d8710a2186461d8b51accae850207e2ca42e Mon Sep 17 00:00:00 2001 From: Roman Volosatovs Date: Sun, 16 Sep 2018 18:21:05 +0200 Subject: [PATCH 2/4] gotools: 2018-07-20 -> 2018-09-11 --- pkgs/development/tools/gotools/default.nix | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pkgs/development/tools/gotools/default.nix b/pkgs/development/tools/gotools/default.nix index 05e87d084606..76023faf3209 100644 --- a/pkgs/development/tools/gotools/default.nix +++ b/pkgs/development/tools/gotools/default.nix @@ -2,8 +2,8 @@ buildGoPackage rec { name = "gotools-unstable-${version}"; - version = "2018-07-20"; - rev = "be728107ea8275e6f58ba07e246b94181acaab24"; + version = "2018-09-11"; + rev = "677d2ff680c188ddb7dcd2bfa6bc7d3f2f2f75b2"; goPackagePath = "golang.org/x/tools"; goPackageAliases = [ "code.google.com/p/go.tools" ]; @@ -11,7 +11,7 @@ buildGoPackage rec { src = fetchgit { inherit rev; url = "https://go.googlesource.com/tools"; - sha256 = "1vkc87qcnfybfcgq9kbwbwzvvzrwm6ar25q5i8z3q26b8dpaxmlw"; + sha256 = "0vp1w1haqcjd82dxd6x9xrllbfwvm957rxwkpji96cgvhsli2bq5"; }; goDeps = ./deps.nix; From 4a8a3de99f0b6cbbe20577a0ae3938b1d050bf62 Mon Sep 17 00:00:00 2001 From: Roman Volosatovs Date: Sun, 16 Sep 2018 18:21:50 +0200 Subject: [PATCH 3/4] go2nix: goimports -> gotools --- pkgs/development/tools/go2nix/default.nix | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkgs/development/tools/go2nix/default.nix b/pkgs/development/tools/go2nix/default.nix index 5ef12d88c06c..585f10336567 100644 --- a/pkgs/development/tools/go2nix/default.nix +++ b/pkgs/development/tools/go2nix/default.nix @@ -1,4 +1,4 @@ -{ stdenv, buildGoPackage, go-bindata, goimports, nix-prefetch-git, git, makeWrapper, +{ stdenv, buildGoPackage, go-bindata, gotools, nix-prefetch-git, git, makeWrapper, fetchFromGitHub }: buildGoPackage rec { @@ -19,7 +19,7 @@ buildGoPackage rec { outputs = [ "bin" "out" "man" ]; - buildInputs = [ go-bindata goimports makeWrapper ]; + buildInputs = [ go-bindata gotools makeWrapper ]; preBuild = ''go generate ./...''; postInstall = '' From be506296d233d2f9112853fc8880a07240f335a9 Mon Sep 17 00:00:00 2001 From: Roman Volosatovs Date: Sun, 16 Sep 2018 18:22:44 +0200 Subject: [PATCH 4/4] godef: 20170920 -> 1.0.0 --- pkgs/development/tools/godef/default.nix | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/pkgs/development/tools/godef/default.nix b/pkgs/development/tools/godef/default.nix index 3227ed8eec2e..497c765b5b1c 100644 --- a/pkgs/development/tools/godef/default.nix +++ b/pkgs/development/tools/godef/default.nix @@ -2,8 +2,8 @@ buildGoPackage rec { name = "godef-${version}"; - version = "20170920-${stdenv.lib.strings.substring 0 7 rev}"; - rev = "b692db1de5229d4248e23c41736b431eb665615d"; + version = "1.0.0"; + rev = "7b4626be9fa8081987905fd4719d2f6628f9d8b5"; goPackagePath = "github.com/rogpeppe/godef"; excludedPackages = "go/printer/testdata"; @@ -11,13 +11,13 @@ buildGoPackage rec { src = fetchgit { inherit rev; url = "https://github.com/rogpeppe/godef"; - sha256 = "0xqp9smfyznm8v2iy4wyy3kd24mga12fx0y0896qimac4hj2al15"; + sha256 = "0zhw4ba19hy0kv74c58ax759h8721khmwj04fak2y5800ymsgndg"; }; meta = { description = "Print where symbols are defined in Go source code"; homepage = https://github.com/rogpeppe/godef/; - maintainers = with stdenv.lib.maintainers; [ vdemeester ]; + maintainers = with stdenv.lib.maintainers; [ vdemeester rvolosatovs ]; license = stdenv.lib.licenses.bsd3; }; }