From 2e860868fe28810f45f5d64df766959bf117f366 Mon Sep 17 00:00:00 2001 From: Eelco Dolstra Date: Fri, 28 Oct 2022 17:05:03 +0200 Subject: [PATCH] nixos/modules/misc/documentation.nix: Don't use toString on a path It gives a warning on the lazy-trees branch of Nix (https://github.com/NixOS/nix/pull/6530) and should generally be avoided because it causes an unnecessary copy to the store. --- nixos/modules/misc/documentation.nix | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/nixos/modules/misc/documentation.nix b/nixos/modules/misc/documentation.nix index e85ad4efd008..aa6e40f43705 100644 --- a/nixos/modules/misc/documentation.nix +++ b/nixos/modules/misc/documentation.nix @@ -56,6 +56,7 @@ let ) pkgSet; in scrubbedEval.options; + baseOptionsJSON = let filter = @@ -67,9 +68,9 @@ let ); in pkgs.runCommand "lazy-options.json" { - libPath = filter "${toString pkgs.path}/lib"; - pkgsLibPath = filter "${toString pkgs.path}/pkgs/pkgs-lib"; - nixosPath = filter "${toString pkgs.path}/nixos"; + libPath = filter (pkgs.path + "/lib"); + pkgsLibPath = filter (pkgs.path + "/pkgs/pkgs-lib"); + nixosPath = filter (pkgs.path + "/nixos"); modules = map (p: ''"${removePrefix "${modulesPath}/" (toString p)}"'') docModules.lazy; } '' export NIX_STORE_DIR=$TMPDIR/store @@ -99,6 +100,7 @@ let exit 1 } >&2 ''; + inherit (cfg.nixos.options) warningsAreErrors allowDocBook; };