gador/nixpkgs
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

workflows/labels: count approving reviewers, not reviews

Browse Source 
A single reviewer approving a Pull Request multiple times should only
count once.
This commit is contained in:
Wolfgang Walther
2025-06-14 13:53:01 +02:00
parent 5cfe0cd778
commit 2e03351248
1 changed files with 7 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
.github/workflows/labels.yml vendored
View File

@@ -96,7 +96,7 @@ jobs:
name == '12.approved-by: package-maintainer'
)
const approvals =
const approvals = new Set(
(await github.paginate(github.rest.pulls.listReviews, {
owner: context.repo.owner,
repo: context.repo.repo,
@@ -104,15 +104,16 @@ jobs:
}))
.filter(review => review.state == 'APPROVED')
.map(review => review.user.id)
const maintainers = Object.keys(
JSON.parse(await readFile('comparison/maintainers.json', 'utf-8'))
)
const maintainers = new Set(Object.keys(
JSON.parse(await readFile('comparison/maintainers.json', 'utf-8'))
))
// And the labels that should be there
const after = JSON.parse(await readFile('comparison/changed-paths.json', 'utf-8')).labels
if (approvals.length > 0) after.push(`12.approvals: ${approvals.length > 2 ? '3+' : approvals.length}`)
if (maintainers.some(id => approvals.includes(id))) after.push('12.approved-by: package-maintainer')
if (approvals.size > 0) after.push(`12.approvals: ${approvals.size > 2 ? '3+' : approvals.size}`)
if (Array.from(maintainers).some(approvals.has)) after.push('12.approved-by: package-maintainer')
// Remove the ones not needed anymore
await Promise.all(