From 0030acac9e980e5b2e3eb2828d4c61e7bd86ddea Mon Sep 17 00:00:00 2001 From: Luna Nova Date: Tue, 7 Apr 2026 14:16:45 -0700 Subject: [PATCH 1/4] rocmPackages.miopen: add bnorm impureTest Repro for 'Internal error while accessing SQLite database: table config has no column named mode' --- pkgs/development/rocm-modules/miopen/default.nix | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/pkgs/development/rocm-modules/miopen/default.nix b/pkgs/development/rocm-modules/miopen/default.nix index 7a6eb06b4999..4718ea0e4949 100644 --- a/pkgs/development/rocm-modules/miopen/default.nix +++ b/pkgs/development/rocm-modules/miopen/default.nix @@ -285,7 +285,12 @@ stdenv.mkDerivation (finalAttrs: { requiredSystemFeatures = [ "big-parallel" ]; passthru.impureTests = { - # bash $(nix-build -A rocmPackages.miopen.passthru.impureTests.conv) + # bash $(nix-build -A rocmPackages.miopen.passthru.impureTests.conv) etc + bnorm = callPackage ./test-runtime-compilation.nix { + miopen = finalAttrs.finalPackage; + name = "bnorm"; + testScript = "MIOpenDriver bnorm -n 16 -c 16 -H 512 -W 512 -m 1 -F 1 -s 1 -r 1"; + }; conv = callPackage ./test-runtime-compilation.nix { miopen = finalAttrs.finalPackage; name = "conv"; From 853d5aa780730a58366605d06b9e45eabe63ef03 Mon Sep 17 00:00:00 2001 From: Luna Nova Date: Tue, 7 Apr 2026 14:17:13 -0700 Subject: [PATCH 2/4] rocmPackages.miopen: disable MIOPEN_USE_SQLITE_PERFDB to fix bnorm crash --- pkgs/development/rocm-modules/miopen/default.nix | 1 - 1 file changed, 1 deletion(-) diff --git a/pkgs/development/rocm-modules/miopen/default.nix b/pkgs/development/rocm-modules/miopen/default.nix index 4718ea0e4949..6d894fc47575 100644 --- a/pkgs/development/rocm-modules/miopen/default.nix +++ b/pkgs/development/rocm-modules/miopen/default.nix @@ -203,7 +203,6 @@ stdenv.mkDerivation (finalAttrs: { "-DAMDGPU_TARGETS=${lib.concatStringsSep ";" supportedTargets}" "-DGPU_TARGETS=${lib.concatStringsSep ";" supportedTargets}" "-DGPU_ARCHS=${lib.concatStringsSep ";" supportedTargets}" - "-DMIOPEN_USE_SQLITE_PERFDB=ON" "-DCMAKE_VERBOSE_MAKEFILE=ON" "-DCMAKE_MODULE_PATH=${clr}/hip/cmake" "-DCMAKE_BUILD_TYPE=Release" From 61efb76ea10cd9d2982900d1f3bc7606020676ee Mon Sep 17 00:00:00 2001 From: Luna Nova Date: Tue, 7 Apr 2026 14:56:35 -0700 Subject: [PATCH 3/4] rocmPackages.miopen: add impureTest for droupout kernels --- pkgs/development/rocm-modules/miopen/default.nix | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/pkgs/development/rocm-modules/miopen/default.nix b/pkgs/development/rocm-modules/miopen/default.nix index 6d894fc47575..88d824355ed3 100644 --- a/pkgs/development/rocm-modules/miopen/default.nix +++ b/pkgs/development/rocm-modules/miopen/default.nix @@ -295,6 +295,11 @@ stdenv.mkDerivation (finalAttrs: { name = "conv"; testScript = "MIOpenDriver conv -n 1 -c 1 -H 4 -W 4 -k 1 -y 3 -x 3 -p 0 -q 0 -V 0"; }; + dropout = callPackage ./test-runtime-compilation.nix { + miopen = finalAttrs.finalPackage; + name = "dropout"; + testScript = "MIOpenDriver dropout -d 64,32,14,14"; + }; pool = callPackage ./test-runtime-compilation.nix { miopen = finalAttrs.finalPackage; name = "pool"; From 9342064af943ad960842a4f301b246e71b74cab6 Mon Sep 17 00:00:00 2001 From: Paul Mulders Date: Tue, 7 Apr 2026 14:41:41 +0200 Subject: [PATCH 4/4] miopen: fix src/comgr.cpp patching for HIPRTC compile ROCM PATH Co-authored-by: Luna Nova --- pkgs/development/rocm-modules/miopen/default.nix | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/pkgs/development/rocm-modules/miopen/default.nix b/pkgs/development/rocm-modules/miopen/default.nix index 88d824355ed3..396f23b00291 100644 --- a/pkgs/development/rocm-modules/miopen/default.nix +++ b/pkgs/development/rocm-modules/miopen/default.nix @@ -23,6 +23,7 @@ half, boost, sqlite, + symlinkJoin, bzip2, lbzip2, nlohmann_json, @@ -82,6 +83,15 @@ let ) ); + # for hiprtcCompileProgram (dropout kernels require rocrand in -I at runtime) + hiprtcCompileRocmPath = symlinkJoin { + name = "miopen-hiprtc-compile-rocm-path"; + paths = [ + clr + rocrand + ]; + }; + # Kernel databases moved from Git LFS to DVC (anonymous s3 bucket s3://therock-dvc/rocm-libraries) fetchKdb = name: @@ -243,7 +253,7 @@ stdenv.mkDerivation (finalAttrs: { patchShebangs test src/composable_kernel fin utils install_deps.cmake substituteInPlace src/comgr.cpp \ - --replace-fail '"/opt/rocm"' '"${clr}"' + --replace-fail '"/opt/rocm"' '"${hiprtcCompileRocmPath}"' '' + linkKDBsTo "src/kernels" + ''