diff --git a/pkgs/development/python-modules/torch/source/default.nix b/pkgs/development/python-modules/torch/source/default.nix index cf1794581f51..eb13db86a483 100644 --- a/pkgs/development/python-modules/torch/source/default.nix +++ b/pkgs/development/python-modules/torch/source/default.nix @@ -1,7 +1,6 @@ { stdenv, lib, - pkgs, fetchFromGitHub, fetchFromGitLab, fetchpatch, @@ -251,9 +250,6 @@ let "Magma cudaPackages does not match cudaPackages" = cudaSupport && (effectiveMagma.cudaPackages.cudaMajorMinorVersion != cudaPackages.cudaMajorMinorVersion); - # Should be fixed by WIP https://github.com/NixOS/nixpkgs/pull/438399 - "ROCm support on non-default python versions is temporarily broken" = - rocmSupport && (pkgs.python3.version != python.version); }; unroll-src = writeShellScript "unroll-src" '' diff --git a/pkgs/development/rocm-modules/6/composable_kernel/base.nix b/pkgs/development/rocm-modules/6/composable_kernel/base.nix index 251efb63946d..6856b3378576 100644 --- a/pkgs/development/rocm-modules/6/composable_kernel/base.nix +++ b/pkgs/development/rocm-modules/6/composable_kernel/base.nix @@ -8,6 +8,7 @@ rocm-merged-llvm, clr, rocminfo, + python3, hipify, gitMinimal, gtest, @@ -69,6 +70,7 @@ stdenv.mkDerivation (finalAttrs: { clr hipify zstd + python3 ]; buildInputs = [ diff --git a/pkgs/development/rocm-modules/6/hiprt/default.nix b/pkgs/development/rocm-modules/6/hiprt/default.nix index 01deca5685bd..2ba4cd5dcbfe 100644 --- a/pkgs/development/rocm-modules/6/hiprt/default.nix +++ b/pkgs/development/rocm-modules/6/hiprt/default.nix @@ -5,6 +5,7 @@ cmake, clr, gcc, + python3, }: stdenv.mkDerivation (finalAttrs: { @@ -25,6 +26,7 @@ stdenv.mkDerivation (finalAttrs: { nativeBuildInputs = [ gcc # required for replacing easy-encryption binary cmake + python3 ]; buildInputs = [ diff --git a/pkgs/development/rocm-modules/6/rccl/default.nix b/pkgs/development/rocm-modules/6/rccl/default.nix index 4e7d32bd4bc4..b4c24708eece 100644 --- a/pkgs/development/rocm-modules/6/rccl/default.nix +++ b/pkgs/development/rocm-modules/6/rccl/default.nix @@ -11,6 +11,7 @@ mscclpp, perl, hipify, + python3, gtest, chrpath, rocprofiler, @@ -62,6 +63,7 @@ stdenv.mkDerivation (finalAttrs: { clr perl hipify + python3 autoPatchelfHook # ASAN doesn't add rpath without this ]; diff --git a/pkgs/development/rocm-modules/6/rocminfo/default.nix b/pkgs/development/rocm-modules/6/rocminfo/default.nix index 19d1f76dbbc6..18166bc780df 100644 --- a/pkgs/development/rocm-modules/6/rocminfo/default.nix +++ b/pkgs/development/rocm-modules/6/rocminfo/default.nix @@ -30,13 +30,15 @@ stdenv.mkDerivation (finalAttrs: { sha256 = "sha256-fQPtO5TNbCbaZZ7VtGkkqng5QZ+FcScdh1opWr5YkLU="; }; + strictDeps = true; + nativeBuildInputs = [ cmake rocm-cmake + python3 ]; buildInputs = [ rocm-runtime ]; - propagatedBuildInputs = [ python3 ]; cmakeFlags = [ "-DROCRTST_BLD_TYPE=Release" ]; prePatch = '' @@ -58,6 +60,7 @@ stdenv.mkDerivation (finalAttrs: { description = "ROCm Application for Reporting System Info"; homepage = "https://github.com/ROCm/rocminfo"; license = licenses.ncsa; + mainProgram = "rocminfo"; maintainers = with maintainers; [ lovesegfault ]; teams = [ teams.rocm ]; platforms = platforms.linux;